fix(firecrawl): reject malformed 2xx response envelopes (#111210)

Alix-007 · steipete · web-flow · commit 990916c6ac87 · 2026-07-19T20:41:48.000-07:00
* fix(firecrawl): reject malformed JSON envelopes

* test(firecrawl): use canonical plugin config fixture

Co-authored-by: Alix-007 &lt;li.long15@xydigit.com&gt;

---------

Co-authored-by: Peter Steinberger &lt;steipete@gmail.com&gt;
diff --git a/extensions/firecrawl/src/firecrawl-client.ts b/extensions/firecrawl/src/firecrawl-client.ts
@@ -1,6 +1,6 @@
 // Firecrawl plugin module implements firecrawl client behavior.
 import type { OpenClawConfig } from "openclaw/plugin-sdk/config-contracts";
-import { readProviderJsonResponse } from "openclaw/plugin-sdk/provider-http";
+import { readProviderJsonObjectResponse } from "openclaw/plugin-sdk/provider-http";
 import {
   DEFAULT_CACHE_TTL_MINUTES,
   markdownToText,
@@ -71,7 +71,7 @@ async function readFirecrawlJsonResponse(
   label: string,
   opts?: { maxBytes?: number },
 ): Promise<Record<string, unknown>> {
-  return await readProviderJsonResponse<Record<string, unknown>>(response, label, opts);
+  return await readProviderJsonObjectResponse(response, label, opts);
 }
 
 type FirecrawlSearchParams = {
diff --git a/extensions/firecrawl/src/firecrawl-tools.test.ts b/extensions/firecrawl/src/firecrawl-tools.test.ts
@@ -1199,6 +1199,39 @@ describe("firecrawl tools", () => {
     ).rejects.toThrow("Firecrawl Search API error: malformed JSON response");
   });
 
+  it.each([
+    ["null", "null"],
+    ["array", "[]"],
+  ])("rejects a %s Firecrawl search envelope with a stable provider error", async (kind, body) => {
+    global.fetch = vi.fn(
+      async () =>
+        new Response(body, {
+          status: 200,
+          headers: { "content-type": "application/json" },
+        }),
+    ) as typeof fetch;
+
+    await expect(
+      runActualFirecrawlSearch({
+        cfg: {
+          plugins: {
+            entries: {
+              firecrawl: {
+                config: {
+                  webSearch: {
+                    baseUrl: "https://api.firecrawl.dev",
+                  },
+                },
+              },
+            },
+          },
+        } as OpenClawConfig,
+        query: `openclaw malformed ${kind} search`,
+        access: "keyless",
+      }),
+    ).rejects.toThrow("Firecrawl Search API error: malformed JSON response");
+  });
+
   it("bounds successful Firecrawl JSON bodies before parsing", async () => {
     const streamed = createStreamingResponse({
       chunkCount: 32,
@@ -1251,15 +1284,51 @@ describe("firecrawl tools", () => {
     ).rejects.toThrow("Firecrawl fetch failed: malformed JSON response");
   });
 
+  it.each([
+    ["null", "null"],
+    ["array", "[]"],
+  ])("rejects a %s Firecrawl scrape envelope with a stable provider error", async (kind, body) => {
+    global.fetch = vi.fn(
+      async () =>
+        new Response(body, {
+          status: 200,
+          headers: { "content-type": "application/json" },
+        }),
+    ) as typeof fetch;
+
+    await expect(
+      runActualFirecrawlScrape({
+        cfg: {
+          plugins: {
+            entries: {
+              firecrawl: {
+                config: {
+                  webFetch: {
+                    baseUrl: "https://api.firecrawl.dev",
+                  },
+                },
+              },
+            },
+          },
+        } as OpenClawConfig,
+        url: `https://example.com/firecrawl-malformed-${kind}-scrape`,
+        extractMode: "markdown",
+        access: "keyless",
+      }),
+    ).rejects.toThrow("Firecrawl fetch failed: malformed JSON response");
+  });
+
   it("respects positive numeric overrides for scrape and cache behavior", () => {
     const cfg = {
-      tools: {
-        web: {
-          fetch: {
-            firecrawl: {
-              onlyMainContent: false,
-              maxAgeMs: 1234,
-              timeoutSeconds: 42,
+      plugins: {
+        entries: {
+          firecrawl: {
+            config: {
+              webFetch: {
+                onlyMainContent: false,
+                maxAgeMs: 1234,
+                timeoutSeconds: 42,
+              },
             },
           },
         },
