perf(gateway): skip force port scan when free

steipete · steipete · commit 935f078a89f0 · 2026-05-03T15:52:57.000+01:00
diff --git a/src/cli/ports.ts b/src/cli/ports.ts
@@ -266,6 +266,10 @@ export async function forceFreePortAndWait(
   let killed: PortProcess[] = [];
   let useFuserFallback = false;
 
+  if (!(await isPortBusy(port))) {
+    return { killed, waitedMs: 0, escalatedToSigkill: false };
+  }
+
   try {
     killed = forceFreePort(port);
   } catch (err) {
diff --git a/src/cli/program.force.test.ts b/src/cli/program.force.test.ts
@@ -32,6 +32,9 @@ describe("gateway --force helpers", () => {
     originalKill = process.kill.bind(process);
     originalPlatform = process.platform;
     tryListenOnPortMock.mockReset();
+    tryListenOnPortMock.mockRejectedValue(
+      Object.assign(new Error("in use"), { code: "EADDRINUSE" }),
+    );
     // Pin to linux so all lsof tests are platform-invariant.
     Object.defineProperty(process, "platform", { value: "linux", configurable: true });
   });
@@ -59,12 +62,8 @@ describe("gateway --force helpers", () => {
     expect(listPortListeners(18789)).toEqual([]);
   });
 
-  it("does not re-scan lsof when no listeners were killed", async () => {
-    (execFileSync as unknown as Mock).mockImplementation(() => {
-      const err = new Error("no matches") as NodeJS.ErrnoException & { status?: number };
-      err.status = 1; // lsof uses exit 1 for no matches
-      throw err;
-    });
+  it("skips lsof when the port is already bindable", async () => {
+    tryListenOnPortMock.mockResolvedValue(undefined);
 
     const result = await forceFreePortAndWait(18789, { timeoutMs: 500, intervalMs: 100 });
 
@@ -73,7 +72,7 @@ describe("gateway --force helpers", () => {
       waitedMs: 0,
       escalatedToSigkill: false,
     });
-    expect(execFileSync).toHaveBeenCalledOnce();
+    expect(execFileSync).not.toHaveBeenCalled();
   });
 
   it("throws when lsof missing", () => {
@@ -181,7 +180,9 @@ describe("gateway --force helpers", () => {
       }
       return "18789/tcp: 4242\n";
     });
-    tryListenOnPortMock.mockResolvedValue(undefined);
+    tryListenOnPortMock
+      .mockRejectedValueOnce(Object.assign(new Error("in use"), { code: "EADDRINUSE" }))
+      .mockResolvedValue(undefined);
 
     const result = await forceFreePortAndWait(18789, { timeoutMs: 500, intervalMs: 100 });
 
@@ -216,6 +217,7 @@ describe("gateway --force helpers", () => {
       .mockRejectedValueOnce(busyErr)
       .mockRejectedValueOnce(busyErr)
       .mockRejectedValueOnce(busyErr)
+      .mockRejectedValueOnce(busyErr)
       .mockResolvedValueOnce(undefined);
 
     const promise = forceFreePortAndWait(18789, {
