test(doctor): satisfy lint for session lock checks

giodl73-repo · giodl73-repo · commit 93192bb7abc1 · 2026-06-24T06:35:36.000-07:00
diff --git a/src/commands/doctor-session-locks.test.ts b/src/commands/doctor-session-locks.test.ts
@@ -153,15 +153,18 @@ describe("noteSessionLockHealth", () => {
       staleMs: 30_000,
       readOwnerProcessArgs: () => ["node", "/opt/openclaw/openclaw.mjs", "doctor"],
     });
+    if (!lock) {
+      throw new Error("expected stale session lock");
+    }
 
-    expect(sessionLockToHealthFinding(lock!)).toEqual(
+    expect(sessionLockToHealthFinding(lock)).toEqual(
       expect.objectContaining({
         checkId: "core/doctor/session-locks",
         severity: "warning",
         path: lockPath,
       }),
     );
-    expect(sessionLockToRepairEffect(lock!)).toEqual({
+    expect(sessionLockToRepairEffect(lock)).toEqual({
       kind: "state",
       action: "would-remove-stale-session-lock",
       target: lockPath,
@@ -180,11 +183,14 @@ describe("noteSessionLockHealth", () => {
       staleMs: 30_000,
       readOwnerProcessArgs: () => ["node", "/opt/openclaw/openclaw.mjs", "doctor"],
     });
+    if (!lock) {
+      throw new Error("expected stale session lock");
+    }
 
-    expect(lock?.staleReasons).toEqual(["missing-pid", "invalid-createdAt"]);
-    expect(lock?.removable).toBe(false);
-    expect(sessionLockToHealthFinding(lock!).fixHint).toContain("after the cleanup grace period");
-    expect(sessionLockToRepairEffect(lock!)).toEqual({
+    expect(lock.staleReasons).toEqual(["missing-pid", "invalid-createdAt"]);
+    expect(lock.removable).toBe(false);
+    expect(sessionLockToHealthFinding(lock).fixHint).toContain("after the cleanup grace period");
+    expect(sessionLockToRepairEffect(lock)).toEqual({
       kind: "state",
       action: "would-preserve-mtime-gated-stale-session-lock",
       target: malformedLock,
@@ -235,12 +241,15 @@ describe("noteSessionLockHealth", () => {
       staleMs: 30_000,
       readOwnerProcessArgs: () => ["node", "/opt/openclaw/openclaw.mjs", "doctor"],
     });
+    if (!lock) {
+      throw new Error("expected stale session lock");
+    }
 
-    expect(lock?.staleReasons).toEqual(["too-old"]);
-    expect(sessionLockToHealthFinding(lock!).fixHint).toBe(
+    expect(lock.staleReasons).toEqual(["too-old"]);
+    expect(sessionLockToHealthFinding(lock).fixHint).toBe(
       "OpenClaw is preserving this live owned lock; inspect the owning process if it appears stuck.",
     );
-    expect(sessionLockToRepairEffect(lock!)).toEqual({
+    expect(sessionLockToRepairEffect(lock)).toEqual({
       kind: "state",
       action: "would-preserve-report-only-stale-session-lock",
       target: reportOnlyLock,
diff --git a/src/flows/doctor-core-checks.test.ts b/src/flows/doctor-core-checks.test.ts
@@ -752,9 +752,11 @@ describe("CORE_HEALTH_CHECKS", () => {
   it("registers stale session locks as a legacy-owned structured check", async () => {
     const check = getCheck(createCoreHealthChecks(createDeps()), "core/doctor/session-locks");
 
-    expect(check.repair).toBeTypeOf("function");
+    if (typeof check.repair !== "function") {
+      throw new Error("expected session lock check repair");
+    }
     await expect(
-      check.repair?.(
+      check.repair(
         {
           mode: "fix",
           runtime,
