fix(doctor): suppress false-positive local embedding warning when gateway probe was skipped

ml12580 · ml12580 · commit 91fd25617acd · 2026-06-20T09:46:57.000+08:00
The local memory provider branch in noteMemorySearchHealth only suppressed its "local embeddings are not confirmed ready" warning when the gateway probe reported checked && ready. When `openclaw doctor` (or `openclaw doctor --deep`) ran, the gateway memory probe used the probe:false path and returned checked:false + skipped:true, meaning readiness was never tested — but the local branch still emitted the alarming "not confirmed ready" warning, a false positive that implied a healthy local embedding stack was broken. Mirror the existing key-optional provider branch: when the probe was intentionally skipped, return without warning. A transport timeout still sets checked:false with skipped absent, so it continues to fall through to the warning. Fixes #92582.
diff --git a/src/commands/doctor-memory-search.test.ts b/src/commands/doctor-memory-search.test.ts
@@ -272,6 +272,27 @@ describe("noteMemorySearchHealth", () => {
     expect(firstNoteMessage()).toContain("a local model path is configured");
   });
 
+  it("does not warn when local provider probe was skipped (skipped: true)", async () => {
+    // `openclaw doctor` (and `openclaw doctor --deep`) probes gateway memory
+    // readiness with probe:false, so the gateway returns checked:false +
+    // skipped:true to mean "readiness was not tested", not "embeddings are
+    // broken". Key-optional providers already treat this as non-fatal; the
+    // local provider must do the same so a configured, healthy local embedding
+    // stack is not falsely flagged as "not confirmed ready".
+    // Regression test for: https://github.com/openclaw/openclaw/issues/92582
+    resolveMemorySearchConfig.mockReturnValue({
+      provider: "local",
+      local: { modelPath: "hf:some-org/some-model-GGUF/model.gguf" },
+      remote: {},
+    });
+
+    await noteMemorySearchHealth(cfg, {
+      gatewayMemoryProbe: { checked: false, ready: false, skipped: true },
+    });
+
+    expect(note).not.toHaveBeenCalled();
+  });
+
   it("does not emit provider guidance when no memory runtime is active", async () => {
     resolveActiveMemoryBackendConfig.mockReturnValue(null);
     resolveMemorySearchConfig.mockReturnValue({
diff --git a/src/commands/doctor-memory-search.ts b/src/commands/doctor-memory-search.ts
@@ -472,6 +472,18 @@ export async function noteMemorySearchHealth(
     if (opts?.gatewayMemoryProbe?.checked && opts.gatewayMemoryProbe.ready) {
       return;
     }
+    // When the probe was intentionally skipped (skipped: true / checked: false
+    // from the probe:false path used by `openclaw doctor` and `openclaw doctor
+    // --deep`), we have no embedding readiness information — do not warn. A
+    // skipped probe means readiness was never checked, not that the configured
+    // local provider is broken, so flagging "not confirmed ready" is a false
+    // positive. This mirrors the key-optional provider branch below.
+    // NOTE: a transport timeout also sets checked: false, but skipped stays
+    // false/absent — a timeout is a real diagnostic signal and should fall
+    // through to the warning below.
+    if (opts?.gatewayMemoryProbe?.skipped) {
+      return;
+    }
     const hasExplicitLocalModel = hasLocalEmbeddings(resolved.local);
     const detail = opts?.gatewayMemoryProbe?.error?.trim();
     note(
