fix(browser): accept no-preference in openclaw browser set media

steipete · steipete · commit 913311845ebd · 2026-07-05T06:54:13.000+01:00
The /set/media control route accepts dark|light|no-preference|none, but the
CLI rejected no-preference, so prefers-color-scheme: no-preference could not
be emulated from the CLI. Align the CLI argument, validation, and error text
with the route contract and update the browser-control docs media line.
diff --git a/docs/tools/browser-control.md b/docs/tools/browser-control.md
@@ -400,7 +400,7 @@ These are useful for "make the site behave like X" workflows:
 - Headers: `set headers --headers-json '{"X-Debug":"1"}'` (or the positional form `set headers '{"X-Debug":"1"}'`)
 - HTTP basic auth: `set credentials user pass` (or `--clear`)
 - Geolocation: `set geo <lat> <lon> --origin "https://example.com"` (or `--clear`)
-- Media: `set media dark|light|none` (the underlying `/set/media` route also accepts `no-preference`)
+- Media: `set media dark|light|no-preference|none`
 - Timezone / locale: `set timezone ...`, `set locale ...`
 - Device / viewport:
   - `set device "iPhone 14"` (Playwright device presets)
diff --git a/extensions/browser/src/cli/browser-cli-state.option-collisions.test.ts b/extensions/browser/src/cli/browser-cli-state.option-collisions.test.ts
@@ -177,10 +177,16 @@ describe("browser state option collisions", () => {
     await runBrowserCommand(["set", "media", "sepia"]);
 
     expect(mocks.callBrowserRequest).not.toHaveBeenCalled();
-    expectErrorMessage("Expected dark|light|none");
+    expectErrorMessage("Expected dark|light|no-preference|none");
     expect(getBrowserCliRuntime().exit).toHaveBeenCalledWith(1);
   });
 
+  it("passes no-preference through to /set/media", async () => {
+    const request = await runBrowserCommandAndGetRequest(["set", "media", "no-preference"]);
+
+    expect(request.body).toMatchObject({ colorScheme: "no-preference" });
+  });
+
   it("rejects invalid geolocation numbers before dispatch", async () => {
     await runBrowserCommand(["set", "geo", "48.208", "16.373", "--accuracy", "fast"]);
 
diff --git a/extensions/browser/src/cli/browser-cli-state.ts b/extensions/browser/src/cli/browser-cli-state.ts
@@ -257,15 +257,15 @@ export function registerBrowserStateCommands(
   set
     .command("media")
     .description("Emulate prefers-color-scheme")
-    .argument("<dark|light|none>", "dark/light/none")
+    .argument("<dark|light|no-preference|none>", "dark/light/no-preference/none")
     .option("--target-id <id>", BROWSER_TAB_REFERENCE_HELP)
     .action(async (value: string, opts, cmd) => {
       const parent = parentOpts(cmd);
       const v = normalizeOptionalLowercaseString(value);
       const colorScheme =
-        v === "dark" ? "dark" : v === "light" ? "light" : v === "none" ? "none" : null;
+        v === "dark" || v === "light" || v === "no-preference" || v === "none" ? v : null;
       if (!colorScheme) {
-        defaultRuntime.error(danger("Expected dark|light|none"));
+        defaultRuntime.error(danger("Expected dark|light|no-preference|none"));
         defaultRuntime.exit(1);
         return;
       }
