refactor(records): reuse canonical object guard

vincentkoc · vincentkoc · commit 9122e762d8f5 · 2026-06-23T03:58:08.000+08:00
diff --git a/src/agents/anthropic-tool-projection.ts b/src/agents/anthropic-tool-projection.ts
@@ -1,3 +1,4 @@
+import { isRecord } from "@openclaw/normalization-core/record-coerce";
 import { projectRuntimeToolInputSchema } from "./tool-schema-json-projection.js";
 
 type AnthropicToolDescriptor = {
@@ -33,10 +34,6 @@ export type AnthropicProjectedToolChoice =
   | { readonly type: "none" }
   | ({ readonly type: "tool"; readonly name: string } & AnthropicParallelToolChoice);
 
-function isRecord(value: unknown): value is Record<string, unknown> {
-  return Boolean(value) && typeof value === "object" && !Array.isArray(value);
-}
-
 function isProviderSupportedViolation(violation: string): boolean {
   return violation.endsWith(".$dynamicRef") || violation.endsWith(".$dynamicAnchor");
 }
diff --git a/src/agents/cli-runner/bundle-mcp-claude.ts b/src/agents/cli-runner/bundle-mcp-claude.ts
@@ -2,6 +2,7 @@
  * Claude CLI argument helpers for OpenClaw-managed bundle MCP config.
  */
 import fs from "node:fs/promises";
+import { isRecord } from "@openclaw/normalization-core/record-coerce";
 import { normalizeOptionalString } from "@openclaw/normalization-core/string-coerce";
 
 /** Find an existing Claude `--mcp-config` argument value. */
@@ -45,10 +46,6 @@ export function injectClaudeMcpConfigArgs(
   return next;
 }
 
-function isRecord(value: unknown): value is Record<string, unknown> {
-  return typeof value === "object" && value !== null && !Array.isArray(value);
-}
-
 /** Writes the active per-attempt capture token into OpenClaw's generated Claude MCP config. */
 export async function writeClaudeMcpCaptureConfig(params: {
   mcpConfigPath: string;
diff --git a/src/agents/cli-runner/claude-live-session.ts b/src/agents/cli-runner/claude-live-session.ts
@@ -2,6 +2,7 @@
  * Manages reusable Claude CLI stdio sessions for CLI-backed agent turns.
  */
 import crypto from "node:crypto";
+import { isRecord } from "@openclaw/normalization-core/record-coerce";
 import type { ReplyBackendHandle } from "../../auto-reply/reply/reply-run-registry.js";
 import type { CliBackendConfig } from "../../config/types.js";
 import {
@@ -731,10 +732,6 @@ function parseSessionId(parsed: Record<string, unknown>): string | undefined {
   return sessionId || undefined;
 }
 
-function isRecord(value: unknown): value is Record<string, unknown> {
-  return Boolean(value && typeof value === "object" && !Array.isArray(value));
-}
-
 function normalizePositiveInt(
   value: number | undefined,
   fallback: number,
diff --git a/src/agents/embedded-agent-runner/run/attempt.model-diagnostic-events.ts b/src/agents/embedded-agent-runner/run/attempt.model-diagnostic-events.ts
@@ -1,3 +1,4 @@
+import { isRecord } from "@openclaw/normalization-core/record-coerce";
 /**
  * Emits diagnostic model-call events around embedded-agent stream functions.
  */
@@ -107,10 +108,6 @@ function assignRequestPayloadBytes(state: ModelCallObservationState, payload: un
   }
 }
 
-function isRecord(value: unknown): value is Record<string, unknown> {
-  return Boolean(value) && typeof value === "object" && !Array.isArray(value);
-}
-
 function utf8StringByteLength(value: string): number {
   return Buffer.byteLength(value, "utf8");
 }
diff --git a/src/agents/embedded-agent-runner/session-manager-init.ts b/src/agents/embedded-agent-runner/session-manager-init.ts
@@ -2,6 +2,7 @@
  * Prepares session managers and transcript state before embedded runs.
  */
 import fs from "node:fs/promises";
+import { isRecord } from "@openclaw/normalization-core/record-coerce";
 import { serializeJsonlLine, writeJsonlLines } from "../../config/sessions/transcript-jsonl.js";
 import { invalidateSessionFileRepairCache } from "../session-file-repair.js";
 
@@ -13,10 +14,6 @@ type SessionHeaderEntry = {
 };
 type SessionMessageEntry = { type: "message"; message?: { role?: string } };
 
-function isRecord(value: unknown): value is Record<string, unknown> {
-  return typeof value === "object" && value !== null && !Array.isArray(value);
-}
-
 async function assertExistingHeaderIsReadable(sessionFile: string): Promise<void> {
   const content = await fs.readFile(sessionFile, "utf-8");
   const firstLine = content.split("\n").find((line) => line.trim());
diff --git a/src/agents/embedded-agent-runner/transcript-file-state.ts b/src/agents/embedded-agent-runner/transcript-file-state.ts
@@ -4,6 +4,7 @@
 import { randomUUID } from "node:crypto";
 import fs from "node:fs/promises";
 import path from "node:path";
+import { isRecord } from "@openclaw/normalization-core/record-coerce";
 import { isSessionTranscriptSideAppendEntry } from "../../config/sessions/transcript-tree.js";
 import { CURRENT_SESSION_VERSION } from "../../config/sessions/version.js";
 import { appendRegularFile } from "../../infra/fs-safe.js";
@@ -65,10 +66,6 @@ const repairableToolCallContentTypes = new Set([
 
 const invalidJsonlSlotType = "__openclaw_invalid_jsonl_slot";
 
-function isRecord(value: unknown): value is Record<string, unknown> {
-  return Boolean(value) && typeof value === "object" && !Array.isArray(value);
-}
-
 function isString(value: unknown): value is string {
   return typeof value === "string" && value.trim() !== "";
 }

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+import { isRecord } from "@openclaw/normalization-core/record-coerce";`
`1`	`2`	`/**`
`2`	`3`	`* Emits diagnostic model-call events around embedded-agent stream functions.`
`3`	`4`	`*/`
`@@ -107,10 +108,6 @@ function assignRequestPayloadBytes(state: ModelCallObservationState, payload: un`
`107`	`108`	`}`
`108`	`109`	`}`
`109`	`110`
`110`		`-function isRecord(value: unknown): value is Record<string, unknown> {`
`111`		`- return Boolean(value) && typeof value === "object" && !Array.isArray(value);`
`112`		`-}`
`113`		`-`
`114`	`111`	`function utf8StringByteLength(value: string): number {`
`115`	`112`	`return Buffer.byteLength(value, "utf8");`
`116`	`113`	`}`