refactor: simplify legacy auth provider normalization

steipete · steipete · commit 9082fc37f3ad · 2026-04-10T23:36:08.000+01:00
diff --git a/src/agents/auth-profiles/persisted.ts b/src/agents/auth-profiles/persisted.ts
@@ -215,10 +215,11 @@ export function buildPersistedAuthProfileSecretsStore(
 export function applyLegacyAuthStore(store: AuthProfileStore, legacy: LegacyAuthStore): void {
   for (const [provider, cred] of Object.entries(legacy)) {
     const profileId = `${provider}:default`;
+    const credentialProvider = cred.provider ?? provider;
     if (cred.type === "api_key") {
       store.profiles[profileId] = {
         type: "api_key",
-        provider: String(cred.provider ?? provider),
+        provider: credentialProvider,
         key: cred.key,
         ...(cred.email ? { email: cred.email } : {}),
       };
@@ -227,7 +228,7 @@ export function applyLegacyAuthStore(store: AuthProfileStore, legacy: LegacyAuth
     if (cred.type === "token") {
       store.profiles[profileId] = {
         type: "token",
-        provider: String(cred.provider ?? provider),
+        provider: credentialProvider,
         token: cred.token,
         ...(typeof cred.expires === "number" ? { expires: cred.expires } : {}),
         ...(cred.email ? { email: cred.email } : {}),
@@ -236,7 +237,7 @@ export function applyLegacyAuthStore(store: AuthProfileStore, legacy: LegacyAuth
     }
     store.profiles[profileId] = {
       type: "oauth",
-      provider: String(cred.provider ?? provider),
+      provider: credentialProvider,
       access: cred.access,
       refresh: cred.refresh,
       expires: cred.expires,
