fix(telegram): address PR review comments for sendChatAction retry

Pick-cat · claude · Pick-cat · commit 8f26eb963e70 · 2026-03-30T19:12:28.000+08:00
- Add strictShouldRetry: true to prevent 429 errors from being retried
  via TELEGRAM_RETRY_RE fallback regex
- Rename MAX_SEND_CHAT_ACTION_RETRIES to MAX_SEND_CHAT_ACTION_ATTEMPTS
  since 'attempts' represents total call count, not retry count
- Always log typing failures (remove opts.verbose guard) so production
  issues are visible

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/extensions/telegram/src/send.ts b/extensions/telegram/src/send.ts
@@ -1029,7 +1029,7 @@ export async function sendMessageTelegram(
 }
 
 // Max retry attempts for sendChatAction to prevent infinite loops (issue #56096)
-const MAX_SEND_CHAT_ACTION_RETRIES = 5;
+const MAX_SEND_CHAT_ACTION_ATTEMPTS = 5;
 
 /**
  * Check if an error is recoverable for sendChatAction with stricter rules.
@@ -1061,7 +1061,7 @@ export async function sendTypingTelegram(
   // Use limited retries with exponential backoff for sendChatAction
   // This prevents infinite retry loops (issue #56096)
   const typingRetryConfig: RetryConfig = {
-    attempts: MAX_SEND_CHAT_ACTION_RETRIES,
+    attempts: MAX_SEND_CHAT_ACTION_ATTEMPTS,
     minDelayMs: 1000, // Start with 1s backoff
     maxDelayMs: 30_000, // Cap at 30s
     jitter: 0.2,
@@ -1073,6 +1073,7 @@ export async function sendTypingTelegram(
     retry: typingRetryConfig,
     verbose: opts.verbose,
     shouldRetry: shouldRetrySendChatAction,
+    strictShouldRetry: true,
   });
   const threadParams = buildTypingThreadParams(target.messageThreadId ?? opts.messageThreadId);
 
@@ -1089,11 +1090,9 @@ export async function sendTypingTelegram(
   } catch (err) {
     // Log but don't fail - typing indicator is non-critical
     // This ensures the main message flow continues even if typing fails
-    if (opts.verbose) {
-      sendLogger.warn(
-        `sendTypingTelegram failed after ${MAX_SEND_CHAT_ACTION_RETRIES} retries, continuing: ${formatErrorMessage(err)}`,
-      );
-    }
+    sendLogger.warn(
+      `sendTypingTelegram failed after ${MAX_SEND_CHAT_ACTION_ATTEMPTS} attempts, continuing: ${formatErrorMessage(err)}`,
+    );
     // Return success anyway - typing indicator is best-effort
   }
 
