addressing codex review

pgondhi987 · pgondhi987 · commit 8d19dd421edf · 2026-05-12T05:49:56.000Z
diff --git a/src/infra/exec-wrapper-resolution.test.ts b/src/infra/exec-wrapper-resolution.test.ts
@@ -521,6 +521,14 @@ describe("extractShellWrapperCommand", () => {
         command: "VwByAGkAdABlAC0ATwB1AHQAcAB1AHQAIABoAGkA",
       },
     },
+    {
+      argv: ["pwsh", "-if", "XML", "-EncodedCommand", "VwByAGkAdABlAC0ATwB1AHQAcAB1AHQAIABoAGkA"],
+      expectedInline: "VwByAGkAdABlAC0ATwB1AHQAcAB1AHQAIABoAGkA",
+      expectedCommand: {
+        isWrapper: true,
+        command: "VwByAGkAdABlAC0ATwB1AHQAcAB1AHQAIABoAGkA",
+      },
+    },
     {
       argv: ["pwsh", "script.ps1", "-en", "VwByAGkAdABlAC0ATwB1AHQAcAB1AHQAIABoAGkA"],
       expectedInline: null,
diff --git a/src/infra/shell-inline-command.test.ts b/src/infra/shell-inline-command.test.ts
@@ -142,6 +142,11 @@ describe("resolveInlineCommandMatch", () => {
       ],
       expected: { command: "VwByAGkAdABlAC0ATwB1AHQAcAB1AHQAIABoAGkA", valueTokenIndex: 4 },
     },
+    {
+      name: "skips PowerShell input format alias values before encoded-command prefixes",
+      argv: ["pwsh", "-if", "XML", "-EncodedCommand", "VwByAGkAdABlAC0ATwB1AHQAcAB1AHQAIABoAGkA"],
+      expected: { command: "VwByAGkAdABlAC0ATwB1AHQAcAB1AHQAIABoAGkA", valueTokenIndex: 4 },
+    },
     {
       name: "extracts PowerShell slash switch forms before script file binding",
       argv: ["pwsh", "/ec", "VwByAGkAdABlAC0ATwB1AHQAcAB1AHQAIABoAGkA"],
diff --git a/src/infra/shell-inline-command.ts b/src/infra/shell-inline-command.ts
@@ -33,7 +33,7 @@ const POWERSHELL_OPTIONS_WITH_SEPARATE_VALUES = new Set([
   ...expandPowerShellSwitchPrefixForms("version", "v"),
   ...expandPowerShellSwitchPrefixForms("windowstyle", "w"),
   ...expandPowerShellSwitchPrefixForms("workingdirectory", "w"),
-  ...expandPowerShellSwitchForms(["ea", "ep", "of", "wd"]),
+  ...expandPowerShellSwitchForms(["ea", "ep", "if", "of", "wd"]),
 ]);
 
 const POSIX_SHELL_OPTIONS_WITH_SEPARATE_VALUES = new Set([
diff --git a/src/infra/system-run-command.test.ts b/src/infra/system-run-command.test.ts
@@ -81,6 +81,7 @@ describe("system run command helpers", () => {
     { argv: ["pwsh", "-en", "ZQBjAGgAbwA="], expected: "ZQBjAGgAbwA=" },
     { argv: ["pwsh", "/NoProfile", "/ec", "ZQBjAGgAbwA="], expected: "ZQBjAGgAbwA=" },
     { argv: ["pwsh", "-win", "hidden", "/ec", "ZQBjAGgAbwA="], expected: "ZQBjAGgAbwA=" },
+    { argv: ["pwsh", "-if", "XML", "-EncodedCommand", "ZQBjAGgAbwA="], expected: "ZQBjAGgAbwA=" },
     { argv: ["busybox", "sh", "-c", "echo hi"], expected: "echo hi" },
     { argv: ["toybox", "ash", "-c", "echo hi"], expected: "echo hi" },
   ])("extractShellCommandFromArgv unwraps %j", ({ argv, expected }) => {
diff --git a/src/node-host/invoke-system-run.test.ts b/src/node-host/invoke-system-run.test.ts
@@ -770,6 +770,8 @@ describe("handleSystemRunInvoke mac app exec host routing", () => {
             executablePath,
             "-win",
             "hidden",
+            "-if",
+            "XML",
             "/NoProfile",
             "/ec",
             "VwByAGkAdABlAC0ATwB1AHQAcAB1AHQAIABoAGkA",
