fix: preserve diagnostic active work owner boundary

moeedahmed · moeedahmed · commit 8b893230e2d1 · 2026-06-27T09:29:00.000+01:00
diff --git a/src/logging/diagnostic.test.ts b/src/logging/diagnostic.test.ts
@@ -988,7 +988,7 @@ describe("stuck session diagnostics threshold", () => {
     );
   });
 
-  it("recovers stale model calls without active embedded-run ownership", async () => {
+  it("keeps stale processing model calls without active embedded-run ownership observe-only", async () => {
     const events: DiagnosticEventPayload[] = [];
     const recoverStuckSession = vi.fn();
     const stuckSessionWarnMs = 30_000;
@@ -1033,11 +1033,7 @@ describe("stuck session diagnostics threshold", () => {
         lastProgressReason: "model_call:started",
       },
     );
-    expectRecoveryCall(
-      recoverStuckSession,
-      { sessionId: "s1", sessionKey: "main", queueDepth: 0, allowActiveAbort: true },
-      ["ageMs", "stateGeneration"],
-    );
+    expect(recoverStuckSession).not.toHaveBeenCalled();
   });
 
   it("does not recover a recent native tool call just because the session is old", async () => {
diff --git a/src/logging/diagnostic.ts b/src/logging/diagnostic.ts
@@ -544,21 +544,7 @@ function isStalledModelCallRecoveryEligible(params: {
     params.classification?.eventType === "session.stalled" &&
     params.classification.classification === "stalled_agent_run" &&
     params.classification.activeWorkKind === "model_call" &&
-    typeof lastProgressAgeMs === "number" &&
-    lastProgressAgeMs >= params.stuckSessionAbortMs
-  );
-}
-
-function isOrphanedActiveWorkRecoveryEligible(params: {
-  classification: SessionAttentionClassification | undefined;
-  activity?: DiagnosticSessionActivitySnapshot;
-  stuckSessionAbortMs: number;
-}): boolean {
-  const lastProgressAgeMs = params.activity?.lastProgressAgeMs;
-  return (
-    params.classification?.eventType === "session.stalled" &&
-    params.classification.classification === "stalled_agent_run" &&
-    params.classification.activeWorkKind !== undefined &&
+    params.activity?.hasActiveEmbeddedRun === true &&
     typeof lastProgressAgeMs === "number" &&
     lastProgressAgeMs >= params.stuckSessionAbortMs
   );
@@ -572,8 +558,7 @@ function isActiveAbortRecoveryEligible(params: {
   return (
     isStalledEmbeddedRunRecoveryEligible(params) ||
     isBlockedToolCallRecoveryEligible(params) ||
-    isStalledModelCallRecoveryEligible(params) ||
-    isOrphanedActiveWorkRecoveryEligible(params)
+    isStalledModelCallRecoveryEligible(params)
   );
 }
 
