fix(qa): reject fractional live token usage

vincentkoc · vincentkoc · commit 8a7906c716d2 · 2026-06-21T14:49:29.000+02:00
diff --git a/extensions/qa-lab/src/token-efficiency-report.test.ts b/extensions/qa-lab/src/token-efficiency-report.test.ts
@@ -134,6 +134,24 @@ describe("token efficiency report", () => {
     ]);
   });
 
+  it("fails live reports with non-integer token usage evidence", () => {
+    const report = buildTokenEfficiencyReport({
+      summary: makeLiveSummary([
+        makeRuntimeParity(
+          "fractional-live-usage",
+          makeCell("openclaw", { inputTokens: 100.5, outputTokens: 0, totalTokens: 100.5 }),
+          makeCell("codex", { inputTokens: 101, outputTokens: 0, totalTokens: 101 }),
+        ),
+      ]),
+    });
+
+    expect(report.pass).toBe(false);
+    expect(report.failures).toEqual([
+      "fractional-live-usage openclaw live usage inputTokens must be a non-negative integer",
+      "fractional-live-usage openclaw live usage totalTokens must be a non-negative integer",
+    ]);
+  });
+
   it("fails empty live runtime summaries instead of treating them as skipped proof", () => {
     const report = buildTokenEfficiencyReport({
       generatedAt: "2026-05-10T00:00:00.000Z",
diff --git a/extensions/qa-lab/src/token-efficiency-report.ts b/extensions/qa-lab/src/token-efficiency-report.ts
@@ -181,6 +181,26 @@ function liveEvidenceFailures(row: TokenEfficiencyRow): string[] {
   return failures;
 }
 
+function liveUsageShapeFailures(
+  scenarioId: string,
+  runtime: RuntimeId,
+  usage: RuntimeParityCell["usage"],
+): string[] {
+  const failures: string[] = [];
+  for (const key of ["inputTokens", "outputTokens", "totalTokens"] as const) {
+    const value: unknown = usage[key];
+    if (
+      typeof value !== "number" ||
+      !Number.isFinite(value) ||
+      !Number.isInteger(value) ||
+      value < 0
+    ) {
+      failures.push(`${scenarioId} ${runtime} live usage ${key} must be a non-negative integer`);
+    }
+  }
+  return failures;
+}
+
 export function buildTokenEfficiencyReport(
   params: BuildTokenEfficiencyReportParams,
 ): TokenEfficiencyReport {
@@ -218,8 +238,16 @@ export function buildTokenEfficiencyReport(
     }),
   );
   const aggregate = buildAggregate(rows);
-  const failures = rows.flatMap((row) => {
-    const rowFailures = liveUsage ? liveEvidenceFailures(row) : [];
+  const failures = rows.flatMap((row, index) => {
+    const result = parityResults[index];
+    const rowFailures =
+      liveUsage && result
+        ? [
+            ...liveUsageShapeFailures(row.scenarioId, "openclaw", result.cells.openclaw.usage),
+            ...liveUsageShapeFailures(row.scenarioId, "codex", result.cells.codex.usage),
+            ...liveEvidenceFailures(row),
+          ]
+        : [];
     if (row.flagged) {
       rowFailures.push(
         `${row.scenarioId} token delta=${formatPercent(row.deltaPercent)} exceeds ${thresholdPercent.toFixed(1)}% Codex increase threshold`,
