Skip to content

Commit 8a5cb85

Browse files
authored
ci: default maturity evidence to all profile (#96595)
1 parent 61d4ff7 commit 8a5cb85

3 files changed

Lines changed: 12 additions & 9 deletions

File tree

.github/workflows/maturity-scorecard.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ jobs:
134134
with:
135135
ref: ${{ inputs.ref }}
136136
expected_sha: ${{ needs.validate_selected_ref.outputs.selected_revision }}
137-
qa_profile: release
137+
qa_profile: all
138138
secrets:
139139
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
140140

@@ -238,8 +238,8 @@ jobs:
238238
}
239239
240240
const evidence = JSON.parse(fs.readFileSync(evidencePath, "utf8"));
241-
if (evidence.profile !== "release") {
242-
throw new Error(`qa-evidence.json profile must be release, got ${JSON.stringify(evidence.profile)}`);
241+
if (evidence.profile !== "all") {
242+
throw new Error(`qa-evidence.json profile must be all, got ${JSON.stringify(evidence.profile)}`);
243243
}
244244
245245
const artifactDir = path.dirname(evidencePath);
@@ -256,8 +256,8 @@ jobs:
256256
const manifestPath = path.join(artifactDir, manifestNames[0]);
257257
const manifest = JSON.parse(fs.readFileSync(manifestPath, "utf8"));
258258
const manifestProfile = manifest.qaProfile ?? evidence.profile;
259-
if (manifestProfile !== "release") {
260-
throw new Error(`QA evidence manifest profile must be release, got ${JSON.stringify(manifestProfile)}`);
259+
if (manifestProfile !== "all") {
260+
throw new Error(`QA evidence manifest profile must be all, got ${JSON.stringify(manifestProfile)}`);
261261
}
262262
if (manifest.targetSha !== targetSha) {
263263
throw new Error(`QA evidence manifest targetSha ${manifest.targetSha} does not match selected ref ${targetSha}`);
@@ -428,14 +428,14 @@ jobs:
428428
cat > "$body_file" <<BODY
429429
## Summary
430430
431-
- render maturity scorecard docs from \`qa/maturity-scores.yaml\` and release QA evidence
431+
- render maturity scorecard docs from \`qa/maturity-scores.yaml\` and full taxonomy QA evidence
432432
- maturity source ref: ${REF_INPUT}
433433
- QA evidence run: ${evidence_run_id}
434434
435435
## Verification
436436
437437
- QA Lab maturity score validation passed
438-
- Maturity scorecard workflow rendered docs from release profile qa-evidence.json artifacts with strict inputs
438+
- Maturity scorecard workflow rendered docs from all profile qa-evidence.json artifacts with strict inputs
439439
BODY
440440
441441
pr_url="$(gh pr list --head "$branch" --state open --json url --jq '.[0].url // ""')"

.github/workflows/qa-profile-evidence.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ on:
1818
qa_profile:
1919
description: Taxonomy QA profile id to run (for example release or all)
2020
required: true
21-
default: release
21+
default: all
2222
type: string
2323
workflow_call:
2424
inputs:

test/scripts/ci-workflow-guards.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -664,6 +664,7 @@ describe("ci workflow guards", () => {
664664
expect(qaEvidenceWorkflow.on.workflow_dispatch.inputs).not.toHaveProperty("fail_on_qa_failure");
665665
expect(qaEvidenceWorkflow.on.workflow_call.inputs).not.toHaveProperty("fail_on_qa_failure");
666666
expect(qaEvidenceWorkflow.on.workflow_dispatch.inputs.qa_profile).not.toHaveProperty("options");
667+
expect(qaEvidenceWorkflow.on.workflow_dispatch.inputs.qa_profile.default).toBe("all");
667668
expect(qaEvidenceWorkflow.on.workflow_call.inputs.qa_profile.type).toBe("string");
668669
const validateProfileStep = qaRunJob.steps.find(
669670
(step) => step.name === "Validate QA profile input",
@@ -682,7 +683,7 @@ describe("ci workflow guards", () => {
682683
// Keep the caller's ref while the callee verifies it against expected_sha.
683684
ref: "${{ inputs.ref }}",
684685
expected_sha: "${{ needs.validate_selected_ref.outputs.selected_revision }}",
685-
qa_profile: "release",
686+
qa_profile: "all",
686687
});
687688
expect(generateJob.with).not.toHaveProperty("fail_on_qa_failure");
688689

@@ -713,6 +714,8 @@ describe("ci workflow guards", () => {
713714
(step) => step.name === "Validate QA evidence manifest",
714715
);
715716
expect(validateManifestStep.run).toContain("qa-profile-evidence-manifest.json");
717+
expect(validateManifestStep.run).toContain("qa-evidence.json profile must be all");
718+
expect(validateManifestStep.run).toContain("QA evidence manifest profile must be all");
716719
expect(validateManifestStep.run).toContain("manifest.targetSha !== targetSha");
717720

718721
expect(qaRunJob.outputs.artifact_name).toBe("${{ steps.evidence.outputs.artifact_name }}");

0 commit comments

Comments
 (0)