fix(agents): quiet extra_body tuning-key collisions

ai-hpc · ai-hpc · commit 8a3739101742 · 2026-06-12T01:33:05.000+02:00
diff --git a/src/agents/embedded-agent-runner-extraparams.test.ts b/src/agents/embedded-agent-runner-extraparams.test.ts
@@ -1284,6 +1284,68 @@ describe("applyExtraParamsToAgent", () => {
     expect(payload).not.toHaveProperty("store");
   });
 
+  it("applies extra_body tuning-key overrides without warning", () => {
+    const warnSpy = vi.spyOn(log, "warn").mockImplementation(() => {});
+    try {
+      const payload = runResponsesPayloadMutationCase({
+        applyProvider: "deepseek",
+        applyModelId: "deepseek-chat",
+        extraParamsOverride: {
+          extra_body: {
+            thinking: { type: "disabled" },
+          },
+        },
+        model: {
+          api: "openai-completions",
+          provider: "deepseek",
+          id: "deepseek-chat",
+          baseUrl: "https://api.deepseek.com/v1",
+        } as Model<"openai-completions">,
+        payload: {
+          messages: [],
+          model: "deepseek-chat",
+          thinking: { type: "enabled" },
+        },
+      });
+
+      expect(payload.thinking).toEqual({ type: "disabled" });
+      expect(warnSpy).not.toHaveBeenCalled();
+    } finally {
+      warnSpy.mockRestore();
+    }
+  });
+
+  it("warns when extra_body overrides framework-managed request scaffolding", () => {
+    const warnSpy = vi.spyOn(log, "warn").mockImplementation(() => {});
+    try {
+      runResponsesPayloadMutationCase({
+        applyProvider: "deepseek",
+        applyModelId: "deepseek-chat",
+        extraParamsOverride: {
+          extra_body: {
+            model: "rogue-model",
+          },
+        },
+        model: {
+          api: "openai-completions",
+          provider: "deepseek",
+          id: "deepseek-chat",
+          baseUrl: "https://api.deepseek.com/v1",
+        } as Model<"openai-completions">,
+        payload: {
+          messages: [],
+          model: "deepseek-chat",
+        },
+      });
+
+      expect(warnSpy).toHaveBeenCalledWith(
+        expect.stringContaining("framework-managed request keys: model"),
+      );
+    } finally {
+      warnSpy.mockRestore();
+    }
+  });
+
   it("forwards chat_template_kwargs params as top-level openai-completions payload fields", () => {
     const payload = runResponsesPayloadMutationCase({
       applyProvider: "vllm",
diff --git a/src/agents/embedded-agent-runner/extra-params.ts b/src/agents/embedded-agent-runner/extra-params.ts
@@ -752,6 +752,8 @@ function createOpenAICompletionsChatTemplateKwargsWrapper(params: {
   };
 }
 
+const FRAMEWORK_MANAGED_EXTRA_BODY_KEYS = new Set(["messages", "model", "stream"]);
+
 function createOpenAICompletionsExtraBodyWrapper(
   baseStreamFn: StreamFn | undefined,
   extraBody: Record<string, unknown>,
@@ -762,9 +764,13 @@ function createOpenAICompletionsExtraBodyWrapper(
       return underlying(model, context, options);
     }
     return streamWithPayloadPatch(underlying, model, context, options, (payloadObj) => {
-      const collisions = Object.keys(extraBody).filter((key) => Object.hasOwn(payloadObj, key));
-      if (collisions.length > 0) {
-        log.warn(`extra_body overwriting request payload keys: ${collisions.join(", ")}`);
+      const clobberedManagedKeys = Object.keys(extraBody).filter(
+        (key) => Object.hasOwn(payloadObj, key) && FRAMEWORK_MANAGED_EXTRA_BODY_KEYS.has(key),
+      );
+      if (clobberedManagedKeys.length > 0) {
+        log.warn(
+          `extra_body overrides framework-managed request keys: ${clobberedManagedKeys.join(", ")}`,
+        );
       }
       Object.assign(payloadObj, extraBody);
     });
