Skip to content

Commit 899f650

Browse files
authored
ci: park timing summary collection (#96930)
1 parent a6a4652 commit 899f650

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2419,7 +2419,8 @@ jobs:
24192419
- macos-swift
24202420
- ios-build
24212421
- android
2422-
if: ${{ !cancelled() && always() && github.event_name != 'push' && (github.event_name != 'pull_request' || !github.event.pull_request.draft) }}
2422+
# Re-enable this job when we want to collect CI timing data for timing optimization.
2423+
if: ${{ false && !cancelled() && always() && github.event_name != 'push' && (github.event_name != 'pull_request' || !github.event.pull_request.draft) }}
24232424
runs-on: ubuntu-24.04
24242425
timeout-minutes: 5
24252426
steps:

test/scripts/ci-workflow-guards.test.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,11 @@ describe("ci workflow guards", () => {
573573
expect(runStep.run).toContain("childEnv[key] = value");
574574
});
575575

576-
it("uploads a CI timing summary after the run lanes finish", () => {
576+
it("keeps the CI timing summary parked for timing optimization work", () => {
577+
expect(readFileSync(".github/workflows/ci.yml", "utf8")).toContain(
578+
"Re-enable this job when we want to collect CI timing data for timing optimization.",
579+
);
580+
577581
const workflow = readCiWorkflow();
578582
const timingJob = workflow.jobs["ci-timings-summary"];
579583

@@ -598,6 +602,7 @@ describe("ci workflow guards", () => {
598602
"ios-build",
599603
"android",
600604
]);
605+
expect(timingJob.if).toContain("false");
601606
expect(timingJob.if).toContain("always()");
602607
expect(timingJob.if).toContain("!cancelled()");
603608

0 commit comments

Comments
 (0)