fix(slack): bypass mention gate for app_mention events

adk47 · claude · adk47 · commit 87b37428f7d3 · 2026-03-23T16:16:05.000-05:00
When requireMention is true, the mention gate checks message text for bot mentions. However, Slack delivers both `message` and `app_mention` events for @mentions, with no guaranteed order. When the `message` event arrives first and is processed (or deduped), the subsequent `app_mention` event can be incorrectly dropped by the mention gate even though Slack has confirmed the bot was explicitly mentioned. This fix skips the mention gate when opts.source is "app_mention", since Slack's app_mention event is only delivered to the mentioned bot's app — the mention is already confirmed at the platform level. The existing dedup + retry mechanism (rememberAppMentionRetryKey / consumeAppMentionRetryKey) addresses part of this issue but doesn't cover the case where the mention gate itself blocks the app_mention event after it passes dedup. Fixes #34833 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
diff --git a/extensions/slack/src/monitor/message-handler/prepare.ts b/extensions/slack/src/monitor/message-handler/prepare.ts
@@ -487,7 +487,13 @@ export async function prepareSlackMessage(params: {
     commandAuthorized,
   });
   const effectiveWasMentioned = mentionGate.effectiveWasMentioned;
-  if (isRoom && shouldRequireMention && mentionGate.shouldSkip) {
+  // When the event source is "app_mention", Slack has already confirmed this bot
+  // was explicitly mentioned. Skip the mention gate — the text-based detection in
+  // mentionGate can fail due to dedup race conditions (message event arrives before
+  // app_mention, sets dedup key, then app_mention is either deduped or the text-based
+  // mention check fails because the message was already processed without wasMentioned).
+  // See: https://github.com/openclaw/openclaw/issues/34833
+  if (isRoom && shouldRequireMention && mentionGate.shouldSkip && opts.source !== "app_mention") {
     ctx.logger.info({ channel: message.channel, reason: "no-mention" }, "skipping channel message");
     const pendingText = (message.text ?? "").trim();
     const fallbackFile = message.files?.[0]?.name
