fix(cli): fail open for unavailable pre-tool relay

MartinClaw · MartinClaw · commit 86e12ca30eb9 · 2026-05-31T19:01:16.000+02:00
diff --git a/src/agents/harness/native-hook-relay.ts b/src/agents/harness/native-hook-relay.ts
@@ -744,7 +744,7 @@ export function renderNativeHookRelayUnavailableResponse(params: {
   const adapter = getNativeHookRelayProviderAdapter(provider);
   const message = params.message?.trim() || "Native hook relay unavailable";
   if (event === "pre_tool_use") {
-    return adapter.renderPreToolUseBlockResponse(message);
+    return adapter.renderNoopResponse(event);
   }
   if (event === "permission_request") {
     return adapter.renderPermissionDecisionResponse("deny", message);
diff --git a/src/cli/native-hook-relay-cli.test.ts b/src/cli/native-hook-relay-cli.test.ts
@@ -137,7 +137,7 @@ describe("native hook relay CLI", () => {
     expect(callGateway).not.toHaveBeenCalled();
   });
 
-  it("renders unavailable output for legacy relay commands without a generation", async () => {
+  it("does not block PreToolUse for legacy relay commands without a generation", async () => {
     const invokeBridge = vi.fn(async () => {
       throw new Error("generation must be non-empty string");
     });
@@ -159,13 +159,7 @@ describe("native hook relay CLI", () => {
     );
 
     expect(exitCode).toBe(0);
-    expect(JSON.parse(stdout.text())).toEqual({
-      hookSpecificOutput: {
-        hookEventName: "PreToolUse",
-        permissionDecision: "deny",
-        permissionDecisionReason: "Native hook relay unavailable",
-      },
-    });
+    expect(stdout.text()).toBe("");
     expect(stderr.text()).toContain("native hook relay unavailable");
     expect(stderr.text()).toContain("generation must be non-empty string");
     expect(callGateway).toHaveBeenCalledWith(
@@ -256,7 +250,7 @@ describe("native hook relay CLI", () => {
     expect(callGateway).not.toHaveBeenCalled();
   });
 
-  it("fails closed for PreToolUse when the gateway relay is unavailable", async () => {
+  it("does not block PreToolUse when the gateway relay is unavailable", async () => {
     const callGateway = vi.fn(async () => {
       throw new Error("gateway closed");
     });
@@ -274,13 +268,7 @@ describe("native hook relay CLI", () => {
     );
 
     expect(exitCode).toBe(0);
-    expect(JSON.parse(stdout.text())).toEqual({
-      hookSpecificOutput: {
-        hookEventName: "PreToolUse",
-        permissionDecision: "deny",
-        permissionDecisionReason: "Native hook relay unavailable",
-      },
-    });
+    expect(stdout.text()).toBe("");
     expect(stderr.text()).toContain("native hook relay unavailable");
   });
 

Original file line number	Diff line number	Diff line change
`@@ -744,7 +744,7 @@ export function renderNativeHookRelayUnavailableResponse(params: {`
`744`	`744`	`const adapter = getNativeHookRelayProviderAdapter(provider);`
`745`	`745`	`const message = params.message?.trim() \|\| "Native hook relay unavailable";`
`746`	`746`	`if (event === "pre_tool_use") {`
`747`		`- return adapter.renderPreToolUseBlockResponse(message);`
	`747`	`+ return adapter.renderNoopResponse(event);`
`748`	`748`	`}`
`749`	`749`	`if (event === "permission_request") {`
`750`	`750`	`return adapter.renderPermissionDecisionResponse("deny", message);`