Skip to content

Commit 82699b1

Browse files
authored
Merge 0d27410 into 4010b81
2 parents 4010b81 + 0d27410 commit 82699b1

2 files changed

Lines changed: 24 additions & 0 deletions

File tree

src/commands/doctor-memory-search.test.ts

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,23 @@ describe("noteMemorySearchHealth", () => {
312312
expect(firstNoteMessage()).toContain("a local model path is configured");
313313
});
314314

315+
it("does not warn when local provider probe was skipped (skipped: true)", async () => {
316+
// When gateway probe is skipped (checked: false, skipped: true), the
317+
// local provider should not produce a false warning — it just means the
318+
// probe was not run, not that embeddings are broken.
319+
resolveMemorySearchConfig.mockReturnValue({
320+
provider: "local",
321+
local: {},
322+
remote: {},
323+
});
324+
325+
await noteMemorySearchHealth(cfg, {
326+
gatewayMemoryProbe: { checked: false, ready: false, skipped: true },
327+
});
328+
329+
expect(note).not.toHaveBeenCalled();
330+
});
331+
315332
it("does not emit provider guidance when no memory runtime is active", async () => {
316333
resolveActiveMemoryBackendConfig.mockReturnValue(null);
317334
resolveMemorySearchConfig.mockReturnValue({

src/commands/doctor-memory-search.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -472,6 +472,13 @@ export async function noteMemorySearchHealth(
472472
if (opts?.gatewayMemoryProbe?.checked && opts.gatewayMemoryProbe.ready) {
473473
return;
474474
}
475+
// When the probe was intentionally skipped (skipped: true / checked: false
476+
// due to probe:false path, e.g. when the gateway sends probe:false even
477+
// during --deep), we have no embedding status information — do not warn.
478+
// A skipped probe does not mean embeddings are unavailable.
479+
if (opts?.gatewayMemoryProbe?.skipped) {
480+
return;
481+
}
475482
const hasExplicitLocalModel = hasLocalEmbeddings(resolved.local);
476483
const hasUnavailableConfiguredLocalModel =
477484
Boolean(normalizeOptionalString(resolved.local.modelPath)) && !hasExplicitLocalModel;

0 commit comments

Comments
 (0)