[AI] fix(gateway): log terminal session persistence failures at the owner catch

SunnyShu0925 · claude · SunnyShu0925 · commit 803e4d5499d0 · 2026-06-29T23:39:14.000+08:00
Log rejected persistGatewaySessionLifecycleEvent at the server-chat persistence owner boundary instead of in cleanup consumers. The owner catch already broadcasts a fallback session snapshot on failure; adding log.error here gives operators visibility into session-store write failures with a single diagnostic site that cannot double-report. Related to #97795 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
diff --git a/src/gateway/server-chat.agent-events.test.ts b/src/gateway/server-chat.agent-events.test.ts
@@ -38,6 +38,11 @@ vi.mock("./session-utils.js", () => ({
   })),
 }));
 
+const { mockLogError } = vi.hoisted(() => ({ mockLogError: vi.fn() }));
+vi.mock("../logging/subsystem.js", () => ({
+  createSubsystemLogger: vi.fn(() => ({ error: mockLogError })),
+}));
+
 import { getRuntimeConfig } from "../config/io.js";
 import { resolveHeartbeatVisibility } from "../infra/heartbeat-visibility.js";
 import {
@@ -69,6 +74,7 @@ describe("agent event handler", () => {
     });
     vi.mocked(loadGatewaySessionRow).mockReset().mockReturnValue(null);
     persistGatewaySessionLifecycleEventMock.mockReset().mockResolvedValue(undefined);
+    mockLogError.mockReset();
     resetAgentRunContextForTest();
   });
 
@@ -2521,6 +2527,11 @@ describe("agent event handler", () => {
       abortedLastRun: false,
     });
     expect(markTrackedRunTerminalPersisted).not.toHaveBeenCalled();
+    expect(mockLogError).toHaveBeenCalledWith(
+      expect.stringContaining(
+        "gateway: failed to persist terminal session lifecycle event for run run-failed-write: Error: disk full",
+      ),
+    );
   });
 
   it("does not clear a same-id retry when an old restart terminal arrives", () => {
diff --git a/src/gateway/server-chat.ts b/src/gateway/server-chat.ts
@@ -9,7 +9,10 @@ import { getRuntimeConfig } from "../config/io.js";
 import { type AgentEventPayload, getAgentRunContext } from "../infra/agent-events.js";
 import { detectErrorKind, type ErrorKind } from "../infra/errors.js";
 import { resolveHeartbeatVisibility } from "../infra/heartbeat-visibility.js";
+import { createSubsystemLogger } from "../logging/subsystem.js";
 import { isAcpSessionKey, isSubagentSessionKey } from "../sessions/session-key-utils.js";
+
+const log = createSubsystemLogger("gateway/server-chat");
 import { resolveAssistantEventPhase } from "../shared/chat-message-content.js";
 import { setSafeTimeout } from "../utils/timer-delay.js";
 import {
@@ -708,7 +711,10 @@ export function createAgentEventHandler({
             markPersisted();
             broadcastSessionChange();
           })
-          .catch(() => {
+          .catch((err: unknown) => {
+            log.error(
+              `gateway: failed to persist terminal session lifecycle event for run ${evt.runId}: ${String(err)}`,
+            );
             // Persistence recovery remains tracked by the controller entry, but
             // subscribers still need a terminal projection instead of hanging.
             broadcastSessionChange(evt);
