fix(agent-core): address review — hoist-safe mock and curly lint

wings1029 · claude · wings1029 · commit 7d6df6af2de2 · 2026-07-07T13:42:20.000+08:00
- Use vi.hoisted pattern for spawnMock to fix ReferenceError in CI
- Wrap one-line if guard in braces per repo curly rule

Co-Authored-By: Claude &lt;noreply@anthropic.com&gt;
diff --git a/packages/agent-core/src/harness/env/nodejs.test.ts b/packages/agent-core/src/harness/env/nodejs.test.ts
@@ -4,12 +4,11 @@ import { PassThrough } from "node:stream";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 import { NodeExecutionEnv, resolveExecTimeoutMs } from "./nodejs.js";
 
-let spawnMock: ReturnType<typeof vi.fn>;
+const { spawnMock } = vi.hoisted(() => ({ spawnMock: vi.fn() }));
 
-vi.mock("node:child_process", () => {
-  spawnMock = vi.fn();
-  return { spawn: spawnMock };
-});
+vi.mock("node:child_process", () => ({
+  spawn: spawnMock,
+}));
 
 afterEach(() => {
   vi.clearAllMocks();
diff --git a/packages/agent-core/src/harness/env/nodejs.ts b/packages/agent-core/src/harness/env/nodejs.ts
@@ -375,7 +375,9 @@ export class NodeExecutionEnv implements ExecutionEnv {
       // child exits before all pipe data is consumed). Without listeners,
       // Node.js throws an uncaught exception that crashes the process.
       const onStreamError = (stream: "stdout" | "stderr", error: Error) => {
-        if (settled) return;
+        if (settled) {
+          return;
+        }
         onAbort();
         settle(
           err(new ExecutionError("spawn_error", `${stream} read error: ${error.message}`, error)),
