msteams: add typingIndicator config and avoid duplicate DM typing

BradGroux · BradGroux · commit 7c36c483d5de · 2026-04-04T03:48:11.000-05:00
diff --git a/extensions/msteams/src/reply-dispatcher.test.ts b/extensions/msteams/src/reply-dispatcher.test.ts
@@ -138,9 +138,28 @@ describe("createMSTeamsReplyDispatcher", () => {
 
     expect(streamInstances).toHaveLength(1);
     expect(streamInstances[0]?.sendInformativeUpdate).toHaveBeenCalledTimes(1);
+    expect(typingCallbacks.onReplyStart).not.toHaveBeenCalled();
+  });
+
+  it("sends native typing indicator for channel conversations by default", async () => {
+    createDispatcher("channel");
+    const options = createReplyDispatcherWithTypingMock.mock.calls[0]?.[0];
+
+    await options.onReplyStart?.();
+
+    expect(streamInstances).toHaveLength(0);
     expect(typingCallbacks.onReplyStart).toHaveBeenCalledTimes(1);
   });
 
+  it("skips native typing indicator when typingIndicator=false", async () => {
+    createDispatcher("channel", { typingIndicator: false });
+    const options = createReplyDispatcherWithTypingMock.mock.calls[0]?.[0];
+
+    await options.onReplyStart?.();
+
+    expect(typingCallbacks.onReplyStart).not.toHaveBeenCalled();
+  });
+
   it("only sends the informative status update once", async () => {
     createDispatcher("personal");
     const options = createReplyDispatcherWithTypingMock.mock.calls[0]?.[0];
diff --git a/extensions/msteams/src/reply-dispatcher.ts b/extensions/msteams/src/reply-dispatcher.ts
@@ -109,6 +109,8 @@ export function createMSTeamsReplyDispatcher(params: {
 
   const blockStreamingEnabled =
     typeof msteamsCfg?.blockStreaming === "boolean" ? msteamsCfg.blockStreaming : false;
+  const typingIndicatorEnabled =
+    typeof msteamsCfg?.typingIndicator === "boolean" ? msteamsCfg.typingIndicator : true;
 
   const pendingMessages: MSTeamsRenderedMessage[] = [];
 
@@ -176,7 +178,10 @@ export function createMSTeamsReplyDispatcher(params: {
     humanDelay: core.channel.reply.resolveHumanDelayConfig(params.cfg, params.agentId),
     onReplyStart: async () => {
       await streamController.onReplyStart();
-      await typingCallbacks?.onReplyStart?.();
+      // Avoid duplicate typing UX in DMs: stream status already shows progress.
+      if (typingIndicatorEnabled && !streamController.hasStream()) {
+        await typingCallbacks?.onReplyStart?.();
+      }
     },
     typingCallbacks,
     deliver: async (payload) => {
diff --git a/src/config/types.msteams.ts b/src/config/types.msteams.ts
@@ -90,6 +90,8 @@ export type MSTeamsConfig = {
   textChunkLimit?: number;
   /** Chunking mode: "length" (default) splits by size; "newline" splits on every newline. */
   chunkMode?: "length" | "newline";
+  /** Send native Teams typing indicator before replies. Default: true for groups/channels; DMs use informative stream status. */
+  typingIndicator?: boolean;
   /** Enable progressive block-by-block message delivery instead of a single reply. */
   blockStreaming?: boolean;
   /** Merge streamed block replies before sending. */
diff --git a/src/config/zod-schema.providers-core.ts b/src/config/zod-schema.providers-core.ts
@@ -495,6 +495,7 @@ export const DiscordAccountSchema = z
     dms: z.record(z.string(), DmConfigSchema.optional()).optional(),
     textChunkLimit: z.number().int().positive().optional(),
     chunkMode: z.enum(["length", "newline"]).optional(),
+    typingIndicator: z.boolean().optional(),
     blockStreaming: z.boolean().optional(),
     blockStreamingCoalesce: BlockStreamingCoalesceSchema.optional(),
     streaming: z.enum(["off", "partial", "block", "progress"]).optional(),
