test: guard doctor command mock calls

steipete · steipete · commit 7a8d86be2760 · 2026-05-12T10:29:04.000+01:00
diff --git a/src/commands/configure.daemon.test.ts b/src/commands/configure.daemon.test.ts
@@ -100,7 +100,7 @@ describe("maybeInstallDaemon", () => {
 
     expect(resolveGatewayInstallToken).toHaveBeenCalledTimes(1);
     expect(buildGatewayInstallPlan).toHaveBeenCalledTimes(1);
-    expect("token" in buildGatewayInstallPlan.mock.calls[0][0]).toBe(false);
+    expect("token" in buildGatewayInstallPlan.mock.calls.at(0)?.[0]).toBe(false);
     expect(serviceInstall).toHaveBeenCalledTimes(1);
   });
 
diff --git a/src/commands/dashboard.links.test.ts b/src/commands/dashboard.links.test.ts
@@ -166,7 +166,7 @@ describe("dashboardCommand", () => {
     // hint string is written to runtime.log, which flows into the same
     // console-captured log file readable by operator.read-scoped devices.
     expect(formatControlUiSshHintMock).toHaveBeenCalledWith({ port: 18789, basePath: undefined });
-    const [sshHintOptions] = formatControlUiSshHintMock.mock.calls[0] ?? [];
+    const [sshHintOptions] = formatControlUiSshHintMock.mock.calls.at(0) ?? [];
     expect(sshHintOptions).not.toHaveProperty("token");
 
     // Double-check: no logged line contains the secret.
diff --git a/src/commands/doctor-bootstrap-size.test.ts b/src/commands/doctor-bootstrap-size.test.ts
@@ -52,7 +52,7 @@ describe("noteBootstrapFileSize", () => {
     });
     await noteBootstrapFileSize({} as OpenClawConfig);
     expect(note).toHaveBeenCalledTimes(1);
-    const [message, title] = note.mock.calls[0] ?? [];
+    const [message, title] = note.mock.calls.at(0) ?? [];
     expect(title).toBe("Bootstrap file size");
     expect(message).toBe(
       [
diff --git a/src/commands/doctor-gateway-daemon-flow.test.ts b/src/commands/doctor-gateway-daemon-flow.test.ts
@@ -307,7 +307,7 @@ describe("maybeRepairGatewayDaemon", () => {
     });
 
     expect(readGatewayRestartHandoffSync).toHaveBeenCalledOnce();
-    const [handoffEnv] = readGatewayRestartHandoffSync.mock.calls[0] as unknown as [
+    const [handoffEnv] = readGatewayRestartHandoffSync.mock.calls.at(0) as unknown as [
       { OPENCLAW_STATE_DIR?: string; OPENCLAW_CONFIG_PATH?: string },
     ];
     expect(handoffEnv?.OPENCLAW_STATE_DIR).toBe("/tmp/openclaw-service");
diff --git a/src/commands/doctor/repair-sequencing.test.ts b/src/commands/doctor/repair-sequencing.test.ts
@@ -306,7 +306,7 @@ describe("doctor repair sequencing", () => {
 
     expect(events).toEqual(["bundled-shadow-cleanup", "openclaw-peer-links", "missing-installs"]);
     expect(mocks.maybeRepairStaleManagedNpmBundledPlugins).toHaveBeenCalledOnce();
-    const cleanupCall = mocks.maybeRepairStaleManagedNpmBundledPlugins.mock.calls[0]?.[0];
+    const cleanupCall = mocks.maybeRepairStaleManagedNpmBundledPlugins.mock.calls.at(0)?.[0];
     expect(cleanupCall?.config.plugins?.entries?.["google-meet"]).toEqual({ enabled: true });
     expect(cleanupCall?.prompter).toEqual({ shouldRepair: true });
     expect(mocks.maybeRepairManagedNpmOpenClawPeerLinks).toHaveBeenCalledWith(
diff --git a/src/commands/doctor/shared/channel-doctor.test.ts b/src/commands/doctor/shared/channel-doctor.test.ts
@@ -305,7 +305,7 @@ describe("channel doctor compatibility mutations", () => {
       cfg,
       READ_ONLY_CHANNEL_DOCTOR_OPTIONS,
     );
-    expect(collectEmptyAllowlistExtraWarnings.mock.calls[0]?.[0]).not.toHaveProperty("cfg");
+    expect(collectEmptyAllowlistExtraWarnings.mock.calls.at(0)?.[0]).not.toHaveProperty("cfg");
   });
 
   it("reuses empty allowlist doctor entries across per-account hooks", () => {
diff --git a/src/commands/doctor/shared/empty-allowlist-scan.test.ts b/src/commands/doctor/shared/empty-allowlist-scan.test.ts
@@ -83,7 +83,7 @@ describe("doctor empty allowlist policy scan", () => {
 
     expect(warnings).toEqual(["extra:channels.signal"]);
     expect(extraWarningsForAccount).toHaveBeenCalledTimes(1);
-    const [warningOptions] = extraWarningsForAccount.mock.calls[0] ?? [];
+    const [warningOptions] = extraWarningsForAccount.mock.calls.at(0) ?? [];
     expect(warningOptions?.prefix).toBe("channels.signal");
   });
 });
diff --git a/src/commands/flows.test.ts b/src/commands/flows.test.ts
@@ -88,7 +88,7 @@ describe("flows commands", () => {
       const runtime = createRuntime();
       await flowsListCommand({ json: true, status: "blocked" }, runtime);
 
-      const payload = JSON.parse(String(vi.mocked(runtime.log).mock.calls[0]?.[0]));
+      const payload = JSON.parse(String(vi.mocked(runtime.log).mock.calls.at(0)?.[0]));
 
       expect(payload).toStrictEqual({
         count: 1,
diff --git a/src/commands/models/shared.test.ts b/src/commands/models/shared.test.ts
@@ -57,7 +57,7 @@ describe("models/shared", () => {
     }));
 
     expect(mocks.replaceConfigFile).toHaveBeenCalledOnce();
-    const [replaceParams] = mocks.replaceConfigFile.mock.calls[0] ?? [];
+    const [replaceParams] = mocks.replaceConfigFile.mock.calls.at(0) ?? [];
     expect(replaceParams?.nextConfig.update).toEqual({ channel: "beta" });
     expect(replaceParams?.baseHash).toBe("config-1");
   });
diff --git a/src/commands/oauth-tls-preflight.doctor.test.ts b/src/commands/oauth-tls-preflight.doctor.test.ts
@@ -44,7 +44,7 @@ describe("noteOpenAIOAuthTlsPrerequisites", () => {
     }
 
     expect(note).toHaveBeenCalledTimes(1);
-    const [message, title] = note.mock.calls[0] as [string, string];
+    const [message, title] = note.mock.calls.at(0) as [string, string];
     expect(title).toBe("OAuth TLS prerequisites");
     expect(message).toContain("brew postinstall ca-certificates");
   });

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ describe("noteBootstrapFileSize", () => {`
`52`	`52`	`});`
`53`	`53`	`await noteBootstrapFileSize({} as OpenClawConfig);`
`54`	`54`	`expect(note).toHaveBeenCalledTimes(1);`
`55`		`- const [message, title] = note.mock.calls[0] ?? [];`
	`55`	`+ const [message, title] = note.mock.calls.at(0) ?? [];`
`56`	`56`	`expect(title).toBe("Bootstrap file size");`
`57`	`57`	`expect(message).toBe(`
`58`	`58`	`[`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ describe("noteOpenAIOAuthTlsPrerequisites", () => {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`expect(note).toHaveBeenCalledTimes(1);`
`47`		`- const [message, title] = note.mock.calls[0] as [string, string];`
	`47`	`+ const [message, title] = note.mock.calls.at(0) as [string, string];`
`48`	`48`	`expect(title).toBe("OAuth TLS prerequisites");`
`49`	`49`	`expect(message).toContain("brew postinstall ca-certificates");`
`50`	`50`	`});`