test(channels): consolidate progress draft error coverage

steipete · hansraj316 · steipete · commit 7a5537e90d39 · 2026-06-13T08:28:49.000+01:00
Co-authored-by: Hansraj Singh Thakur &lt;hansraj136@gmail.com&gt;
diff --git a/src/channels/progress-draft-compositor.test.ts b/src/channels/progress-draft-compositor.test.ts
@@ -163,9 +163,8 @@ describe("createChannelProgressDraftCompositor", () => {
     vi.useFakeTimers();
     const warn = vi.spyOn(console, "warn").mockImplementation(() => {});
     try {
-      // The compositor builds the gate without an onStartError, so the failure must be
-      // observed by the gate's default boundary reporter rather than silently dropped.
-      const update = vi.fn().mockRejectedValue(new Error("send failed"));
+      const error = new Error("send failed");
+      const update = vi.fn().mockRejectedValue(error);
       const progress = createChannelProgressDraftCompositor({
         entry: { streaming: { mode: "progress", progress: { label: "Shelling" } } },
         mode: "progress",
@@ -174,16 +173,14 @@ describe("createChannelProgressDraftCompositor", () => {
         update,
       });
 
-      // A single work event schedules the delayed start timer (no startImmediately).
       await progress.pushToolProgress("🛠️ Exec");
       expect(warn).not.toHaveBeenCalled();
 
-      // Firing the timer runs onStart -> render -> update(), which rejects.
       await vi.advanceTimersByTimeAsync(DEFAULT_PROGRESS_DRAFT_INITIAL_DELAY_MS);
 
       expect(update).toHaveBeenCalled();
       expect(warn).toHaveBeenCalledWith(
-        expect.stringContaining("channel progress draft failed to start"),
+        "[progress-draft] channel progress draft failed to start: Error: send failed",
       );
     } finally {
       vi.useRealTimers();
diff --git a/src/channels/streaming.test.ts b/src/channels/streaming.test.ts
diff --git a/src/channels/streaming.ts b/src/channels/streaming.ts
@@ -553,12 +553,7 @@ export function createChannelProgressDraftGate(params: {
   onStart: () => void | Promise<void>;
   /** Delay before first work event starts a draft; second work event starts immediately. */
   initialDelayMs?: number;
-  /**
-   * Observes a timer-fired startup rejection. The explicit start/noteWork/startNow
-   * paths re-throw to their awaiting caller, but the timer path has no awaiter. When a
-   * caller does not supply this, the gate logs a warning at the helper boundary so the
-   * failure is never silently dropped regardless of which channel built the gate.
-   */
+  /** Reports timer-fired startup failures, which have no awaiting caller. */
   onStartError?: (error: unknown) => void;
   /** Timer implementation, injectable for tests. */
   setTimeoutFn?: typeof setTimeout;
@@ -568,10 +563,7 @@ export function createChannelProgressDraftGate(params: {
   const initialDelayMs = params.initialDelayMs ?? DEFAULT_PROGRESS_DRAFT_INITIAL_DELAY_MS;
   const setTimeoutFn = params.setTimeoutFn ?? setTimeout;
   const clearTimeoutFn = params.clearTimeoutFn ?? clearTimeout;
-  // Boundary default: callers that do not pass onStartError still get an observable
-  // warning for a swallowed timer-fired start failure instead of a silent drop. Use a
-  // lightweight console.warn (matching sibling typing.ts) rather than a structured
-  // logger import, so this SDK-exposed module does not widen its static import surface.
+  // Timer starts have no awaiting caller, so preserve observability at this SDK boundary.
   const reportStartError =
     params.onStartError ??
     ((error: unknown) => {
@@ -628,8 +620,7 @@ export function createChannelProgressDraftGate(params: {
     }
     timer = setTimeoutFn(() => {
       timer = undefined;
-      // Timer start has no awaiter; route the rejection to the (defaulted) reporter so
-      // it is observed rather than silently dropped.
+      // Explicit starts rethrow to callers; timer starts must report at the boundary.
       void start().catch((error: unknown) => {
         reportStartError(error);
       });
diff --git a/src/plugin-sdk/channel-streaming.test.ts b/src/plugin-sdk/channel-streaming.test.ts
@@ -611,17 +611,20 @@ describe("channel-streaming", () => {
 
   it("does not report started when delayed progress startup rejects", async () => {
     vi.useFakeTimers();
+    const error = new Error("draft unavailable");
     const onStart = vi
       .fn<() => Promise<void>>()
-      .mockRejectedValueOnce(new Error("draft unavailable"))
+      .mockRejectedValueOnce(error)
       .mockResolvedValueOnce(undefined);
-    const gate = createChannelProgressDraftGate({ onStart });
+    const onStartError = vi.fn();
+    const gate = createChannelProgressDraftGate({ onStart, onStartError });
 
     await expect(gate.noteWork()).resolves.toBe(false);
     await vi.advanceTimersByTimeAsync(5_000);
 
     expect(onStart).toHaveBeenCalledTimes(1);
     expect(gate.hasStarted).toBe(false);
+    expect(onStartError).toHaveBeenCalledWith(error);
 
     await expect(gate.noteWork()).resolves.toBe(true);
 
