Fix media delivery identity accounting

Kiran Magic · Kiran Magic · commit 774c24ad5cff · 2026-06-15T05:11:55.000+05:30
diff --git a/src/infra/outbound/deliver.test.ts b/src/infra/outbound/deliver.test.ts
@@ -3553,6 +3553,46 @@ describe("deliverOutboundPayloads", () => {
     expect(mocks.appendAssistantMessageToSessionTranscript).not.toHaveBeenCalled();
   });
 
+  it("does not count no-identity media results as delivered", async () => {
+    hookMocks.runner.hasHooks.mockReturnValue(true);
+    const sendText = vi.fn();
+    const sendMedia = vi.fn().mockResolvedValue({
+      channel: "matrix",
+      messageId: "",
+      meta: { error: "media path is not allowed" },
+    });
+    setActivePluginRegistry(
+      createTestRegistry([
+        {
+          pluginId: "matrix",
+          source: "test",
+          plugin: createOutboundTestPlugin({
+            id: "matrix",
+            outbound: { deliveryMode: "direct", sendText, sendMedia },
+          }),
+        },
+      ]),
+    );
+
+    const results = await deliverOutboundPayloads({
+      cfg: {},
+      channel: "matrix",
+      to: "!room:1",
+      payloads: [{ text: "caption", mediaUrl: "file:///tmp/generated-tts.opus" }],
+      mirror: {
+        sessionKey: "agent:main:main",
+        agentId: "main",
+        text: "caption",
+      },
+    });
+
+    expect(results).toStrictEqual([]);
+    expect(sendMedia).toHaveBeenCalledTimes(1);
+    expect(sendText).not.toHaveBeenCalled();
+    expect(hookMocks.runner.runMessageSent).not.toHaveBeenCalled();
+    expect(mocks.appendAssistantMessageToSessionTranscript).not.toHaveBeenCalled();
+  });
+
   it("emits message_sent success for sendPayload deliveries", async () => {
     hookMocks.runner.hasHooks.mockReturnValue(true);
     const sendPayload = vi.fn().mockResolvedValue({ channel: "matrix", messageId: "mx-1" });
diff --git a/src/infra/outbound/deliver.ts b/src/infra/outbound/deliver.ts
@@ -1891,6 +1891,9 @@ async function deliverOutboundPayloadsCore(
               unit.overrides,
             )
           : await deliveryHandler.sendMedia(unit.caption ?? "", unit.mediaUrl, unit.overrides);
+        if (!hasDeliveryResultIdentity(delivery)) {
+          continue;
+        }
         results.push(delivery);
         firstMessageId ??= delivery.messageId;
         lastMessageId = delivery.messageId;
@@ -1916,20 +1919,21 @@ async function deliverOutboundPayloadsCore(
           results: deliveredResults,
         });
         recordDeliveredMirrorPayload(payloadSummary, deliveredResults);
+        completeDeliveryDiagnostics(deliveredResults.length);
+        emitMessageSent({
+          success: true,
+          content: payloadSummary.hookContent ?? payloadSummary.text,
+          messageId: lastMessageId,
+        });
       } else {
         recordPayloadOutcome(
           suppressedPayloadOutcome({
             index: payloadIndex,
             reason: "adapter_returned_no_identity",
           }),
         );
+        completeDeliveryDiagnostics(0);
       }
-      completeDeliveryDiagnostics(results.length - beforeCount);
-      emitMessageSent({
-        success: true,
-        content: payloadSummary.hookContent ?? payloadSummary.text,
-        messageId: lastMessageId,
-      });
     } catch (err) {
       recordPayloadOutcome({
         index: payloadIndex,
