fix(feishu): normalize target IDs with parseFeishuDirectConversationId

schumilin · claude · schumilin · commit 7692637b4ca1 · 2026-04-05T17:32:23.000+08:00
Use the same Feishu ID parser for target recipient matching as for
approver normalization, so all address forms (dm:ou_xxx, open_id:ou_xxx,
feishu:user:ou_xxx) are handled consistently. (Codex P2)

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/extensions/feishu/src/exec-approvals.ts b/extensions/feishu/src/exec-approvals.ts
@@ -70,13 +70,14 @@ export function isFeishuExecApprovalTargetRecipient(params: {
     ...params,
     channel: "feishu",
     matchTarget: ({ target, normalizedSenderId }) => {
-      const to = target.to?.trim();
-      if (!to) {
+      // Use the same parser as approver normalization to handle all
+      // Feishu address forms (user:ou_xxx, dm:ou_xxx, open_id:ou_xxx,
+      // feishu:user:ou_xxx, bare ou_xxx).
+      const parsed = parseFeishuDirectConversationId(target.to);
+      if (!parsed) {
         return false;
       }
-      // Strip "user:" prefix for DM targets
-      const normalized = to.startsWith("user:") ? to.slice(5) : to;
-      return normalized === normalizedSenderId;
+      return parsed === normalizedSenderId;
     },
   });
 }
