fix(ci): ignore quoted Swift event constants

steipete · steipete · commit 753e4a941df1 · 2026-07-05T11:55:21.000-04:00
diff --git a/scripts/check-protocol-event-coverage.mjs b/scripts/check-protocol-event-coverage.mjs
@@ -196,7 +196,8 @@ export function extractSwiftHandledEvents(source, constants = new Map()) {
     const label = SWIFT_CASE_LABEL_RE.exec(line);
     if (label) {
       pushStringLiterals(label[1], sink);
-      for (const reference of label[1].matchAll(SWIFT_QUALIFIED_CONSTANT_RE)) {
+      const constantReferences = sanitizeLineForBraces(label[1]);
+      for (const reference of constantReferences.matchAll(SWIFT_QUALIFIED_CONSTANT_RE)) {
         const value = constants.get(reference[1]);
         if (value) {
           sink.push(value);
diff --git a/test/scripts/check-protocol-event-coverage.test.ts b/test/scripts/check-protocol-event-coverage.test.ts
@@ -109,6 +109,27 @@ describe("extractSwiftHandledEvents", () => {
 
     expect([...constants]).toEqual([["ApprovalBridge.requestedKind", "exec.approval.requested"]]);
   });
+
+  it("does not resolve qualified constants inside quoted case labels", () => {
+    const constants = extractSwiftStaticStringConstants(`
+      enum ApprovalBridge {
+        static let requestedKind = "exec.approval.requested"
+      }
+    `);
+    const handled = extractSwiftHandledEvents(
+      `
+        switch evt.event {
+        case "ApprovalBridge.requestedKind":
+          return .approval
+        default:
+          return nil
+        }
+      `,
+      constants,
+    );
+
+    expect(handled).toEqual(new Set(["ApprovalBridge.requestedKind"]));
+  });
 });
 
 describe("extractKotlinHandledEvents", () => {
