Skip to content

Commit 751a6c2

Browse files
authored
fix(signal): avoid duplicate cli missing note (#96932)
1 parent 899f650 commit 751a6c2

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

extensions/signal/src/core.test.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import {
2323
import { probeSignal } from "./probe.js";
2424
import { clearSignalRuntime } from "./runtime.js";
2525
import {
26+
createSignalCliPathTextInput,
2627
normalizeSignalAccountInput,
2728
parseSignalAllowFromEntries,
2829
signalDmPolicy,
@@ -214,6 +215,13 @@ describe("probeSignal", () => {
214215

215216
expect(status.configured).toBe(true);
216217
});
218+
219+
it("does not show a second missing-binary note before the cliPath prompt", () => {
220+
const input = createSignalCliPathTextInput(async () => true);
221+
222+
expect(input.helpLines).toBeUndefined();
223+
expect(input.helpTitle).toBeUndefined();
224+
});
217225
});
218226

219227
describe("signal outbound", () => {

extensions/signal/src/setup-core.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,10 +193,6 @@ export function createSignalCliPathTextInput(
193193
resolvePath: ({ cfg, accountId, credentialValues }) =>
194194
resolveSignalCliPath({ cfg, accountId, credentialValues }),
195195
shouldPrompt,
196-
helpTitle: "Signal",
197-
helpLines: [
198-
"signal-cli not found. Install it, then rerun this step or set channels.signal.cliPath.",
199-
],
200196
});
201197
}
202198

0 commit comments

Comments
 (0)