fix: block gateway startup on plugin repair warnings

sallyom · sallyom · commit 749f839cbec6 · 2026-07-08T12:56:00.000-04:00
Signed-off-by: sallyom &lt;somalley@redhat.com&gt;
diff --git a/src/commands/doctor-config-preflight.state-migration.test.ts b/src/commands/doctor-config-preflight.state-migration.test.ts
@@ -326,7 +326,7 @@ describe("runDoctorConfigPreflight state migration", () => {
     expect(startupMigrationLeaseRelease).toHaveBeenCalledOnce();
   });
 
-  it("records the startup migration checkpoint when plugin repair warnings are nonblocking", async () => {
+  it("blocks gateway readiness when plugin repair warnings remain", async () => {
     needsStartupMigrationCheckpoint.mockReturnValue(true);
     runPostCorePluginConvergence.mockResolvedValueOnce(
       makeStartupConvergenceResult({
@@ -339,16 +339,15 @@ describe("runDoctorConfigPreflight state migration", () => {
       }),
     );
 
-    await runDoctorConfigPreflight({
-      migrateLegacyConfig: false,
-      invalidConfigNote: false,
-      requireStartupMigrationCheckpoint: true,
-    });
+    await expect(
+      runDoctorConfigPreflight({
+        migrateLegacyConfig: false,
+        invalidConfigNote: false,
+        requireStartupMigrationCheckpoint: true,
+      }),
+    ).rejects.toThrow("Configured plugin discord is not installed");
 
-    expect(recordSuccessfulStartupMigrations).toHaveBeenCalledWith({
-      env: process.env,
-      lease: startupMigrationLease,
-    });
+    expect(recordSuccessfulStartupMigrations).not.toHaveBeenCalled();
     expect(note).toHaveBeenCalledWith(
       "- Configured plugin discord is not installed. Run `openclaw update repair` to retry plugin repair.",
       "Doctor warnings",
diff --git a/src/commands/doctor-config-preflight.ts b/src/commands/doctor-config-preflight.ts
@@ -135,7 +135,7 @@ async function runStartupUpgradeConvergence(params: {
   if (warnings.length > 0) {
     note(warnings.map((warning) => `- ${warning}`).join("\n"), "Doctor warnings");
   }
-  return convergence.errored ? warnings : [];
+  return warnings;
 }
 
 function formatStartupMigrationFailure(params: { warnings: string[]; blockers: string[] }): string {

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ async function runStartupUpgradeConvergence(params: {`
`135`	`135`	`if (warnings.length > 0) {`
`136`	`136`	note(warnings.map((warning) => `- ${warning}`).join("\n"), "Doctor warnings");
`137`	`137`	`}`
`138`		`- return convergence.errored ? warnings : [];`
	`138`	`+ return warnings;`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`function formatStartupMigrationFailure(params: { warnings: string[]; blockers: string[] }): string {`