[AI] fix(memory-core): address ClawSweeper P1/P2 review findings for #94537

SunnyShu0925 · claude · SunnyShu0925 · commit 7492f9a1af8e · 2026-06-26T18:28:42.000+08:00
- P1: preserve existing directory mode across replaceFileAtomic calls
  by stat'ing the pre-created directory and passing its mode as dirMode.
  Also add preserveExistingMode to separate/deep report paths.
- P1: add recall-store-dangling-ref literal to ShortTermAuditIssue.code
  union in the public SDK facade so typed plugin consumers see it.
- P2: align dangling-entry audit predicate with repair by adding
  isShortTermMemoryPath filter, preventing non-short-term source:memory
  entries from inflating the dangling count.
- Add regression test for audit/repair predicate alignment.

Co-Authored-By: Claude Opus 4.8 &lt;noreply@anthropic.com&gt;
diff --git a/extensions/memory-core/src/dreaming-markdown.ts b/extensions/memory-core/src/dreaming-markdown.ts
@@ -75,6 +75,9 @@ export async function writeDailyDreamingPhaseBlock(params: {
   if (shouldWriteInline(params.storage)) {
     inlinePath = resolveDailyMemoryPath(params.workspaceDir, nowMs, params.timezone);
     await fs.mkdir(path.dirname(inlinePath), { recursive: true });
+    // Preserve the existing directory mode so replaceFileAtomic's internal
+    // chmod(dir, dirMode) does not overwrite workspace-relative permissions.
+    const inlineDirMode = (await fs.stat(path.dirname(inlinePath))).mode;
     const original = await fs.readFile(inlinePath, "utf-8").catch((err: unknown) => {
       if ((err as NodeJS.ErrnoException)?.code === "ENOENT") {
         return "";
@@ -96,6 +99,7 @@ export async function writeDailyDreamingPhaseBlock(params: {
       content: withTrailingNewline(updated),
       mode: 0o600,
       preserveExistingMode: true,
+      dirMode: inlineDirMode,
       tempPrefix: "dreaming-inline",
       throwOnCleanupError: true,
     });
@@ -109,6 +113,9 @@ export async function writeDailyDreamingPhaseBlock(params: {
       params.timezone,
     );
     await fs.mkdir(path.dirname(reportPath), { recursive: true });
+    // Preserve the directory mode freshly created by fs.mkdir so
+    // replaceFileAtomic's chmod(dir, dirMode) is a no-op.
+    const reportDirMode = (await fs.stat(path.dirname(reportPath))).mode;
     const report = [
       `# ${params.phase === "light" ? "Light Sleep" : "REM Sleep"}`,
       "",
@@ -119,6 +126,8 @@ export async function writeDailyDreamingPhaseBlock(params: {
       filePath: reportPath,
       content: report,
       mode: 0o600,
+      preserveExistingMode: true,
+      dirMode: reportDirMode,
       tempPrefix: "dreaming-report",
       throwOnCleanupError: true,
     });
@@ -157,10 +166,15 @@ export async function writeDeepDreamingReport(params: {
   if (shouldWriteSeparate(params.storage)) {
     reportPath = resolveSeparateReportPath(params.workspaceDir, "deep", nowMs, params.timezone);
     await fs.mkdir(path.dirname(reportPath), { recursive: true });
+    // Preserve the directory mode freshly created by fs.mkdir so
+    // replaceFileAtomic's chmod(dir, dirMode) is a no-op.
+    const deepDirMode = (await fs.stat(path.dirname(reportPath))).mode;
     await replaceFileAtomic({
       filePath: reportPath,
       content: `# Deep Sleep\n\n${body}\n`,
       mode: 0o600,
+      preserveExistingMode: true,
+      dirMode: deepDirMode,
       tempPrefix: "dreaming-deep",
       throwOnCleanupError: true,
     });
diff --git a/extensions/memory-core/src/short-term-promotion.test.ts b/extensions/memory-core/src/short-term-promotion.test.ts
@@ -3181,6 +3181,45 @@ describe("short-term promotion", () => {
     });
   });
 
+  it("does not count non-short-term source:memory entries as dangling (predicate alignment)", async () => {
+    await withTempWorkspace(async (workspaceDir) => {
+      const memoryDir = path.join(workspaceDir, "memory");
+      await fs.mkdir(memoryDir, { recursive: true });
+      // A source:memory entry whose path does NOT pass isShortTermMemoryPath
+      // (e.g. a dreaming deep-file) should not be reported as a dangling ref
+      // even though the file genuinely doesn't exist. Audit and repair must use
+      // the same predicate to keep --fix re-audit results consistent.
+      await testing.writeRawRecallStore(workspaceDir, {
+        version: 1,
+        updatedAt: "2026-04-04T00:00:00.000Z",
+        entries: {
+          nonShortTerm: {
+            key: "non-short-term",
+            path: "memory/dreaming/deep/2026-04-01.md",
+            startLine: 1,
+            endLine: 1,
+            source: "memory",
+            snippet: "Deep dreaming file path — not a short-term path.",
+            recallCount: 1,
+            totalScore: 0.5,
+            maxScore: 0.5,
+            firstRecalledAt: "2026-04-01T00:00:00.000Z",
+            lastRecalledAt: "2026-04-01T00:00:00.000Z",
+            queryHashes: ["nd1"],
+            recallDays: ["2026-04-01"],
+            conceptTags: [],
+          },
+        },
+      });
+
+      const audit = await auditShortTermPromotionArtifacts({ workspaceDir });
+
+      // The non-short-term-path entry must not inflate the dangling count.
+      expect(audit.danglingRefCount).toBe(0);
+      expect(audit.issues.some((issue) => issue.code === "recall-store-dangling-ref")).toBe(false);
+    });
+  });
+
   it("waits for an active short-term lock before repairing", async () => {
     await withTempWorkspace(async (workspaceDir) => {
       await testing.writeRawRecallStore(workspaceDir, {
diff --git a/extensions/memory-core/src/short-term-promotion.ts b/extensions/memory-core/src/short-term-promotion.ts
@@ -2616,7 +2616,9 @@ export async function auditShortTermPromotionArtifacts(params: {
 
     // Check for dangling references — entries whose source file no longer exists.
     const danglingEntryKeys = Object.keys(store.entries).filter(
-      (key) => store.entries[key]?.source === "memory",
+      (key) =>
+        store.entries[key]?.source === "memory" &&
+        isShortTermMemoryPath(store.entries[key]?.path ?? ""),
     );
     danglingRefCount = 0;
     for (const key of danglingEntryKeys) {
diff --git a/src/plugin-sdk/memory-core-engine-runtime.ts b/src/plugin-sdk/memory-core-engine-runtime.ts
@@ -63,6 +63,7 @@ export type ShortTermAuditIssue = {
     | "recall-store-empty"
     | "recall-store-invalid"
     | "recall-store-over-limit"
+    | "recall-store-dangling-ref"
     | "recall-lock-stale"
     | "recall-lock-unreadable"
     | "qmd-index-missing"
