fix: gate active memory global toggles (#97841)

pgondhi987 · web-flow · commit 738b2be4b49b · 2026-06-30T14:32:37.000+05:30
diff --git a/extensions/active-memory/index.test.ts b/extensions/active-memory/index.test.ts
@@ -471,6 +471,7 @@ describe("active-memory plugin", () => {
     };
     expect(command.name).toBe("active-memory");
     expect(command.acceptsArgs).toBe(true);
+    expect(command.exposeSenderIsOwner).toBe(true);
 
     const offResult = await command.handler({
       channel: "webchat",
@@ -568,6 +569,7 @@ describe("active-memory plugin", () => {
     const offResult = await command.handler({
       channel: "webchat",
       isAuthorizedSender: true,
+      senderIsOwner: true,
       args: "off --global",
       commandBody: "/active-memory off --global",
       config: {},
@@ -617,6 +619,7 @@ describe("active-memory plugin", () => {
     const onResult = await command.handler({
       channel: "webchat",
       isAuthorizedSender: true,
+      senderIsOwner: true,
       args: "on --global",
       commandBody: "/active-memory on --global",
       config: {},
@@ -650,6 +653,30 @@ describe("active-memory plugin", () => {
     expect(runEmbeddedAgent).toHaveBeenCalledTimes(1);
   });
 
+  it("blocks external non-owner callers from changing global active-memory config", async () => {
+    const command = registeredCommands["active-memory"];
+
+    for (const args of ["off --global", "on --global"]) {
+      const result = await command.handler({
+        channel: "telegram",
+        isAuthorizedSender: true,
+        senderIsOwner: false,
+        args,
+        commandBody: `/active-memory ${args}`,
+        config: {},
+        requestConversationBinding: async () => ({ status: "error", message: "unsupported" }),
+        detachConversationBinding: async () => ({ removed: false }),
+        getCurrentConversationBinding: async () => null,
+      });
+
+      expect(result.text).toContain(
+        "global enable/disable changes require owner or operator.admin",
+      );
+    }
+
+    expect(api.runtime.config.mutateConfigFile).not.toHaveBeenCalled();
+  });
+
   it("blocks gateway callers without admin scope from changing global active-memory config", async () => {
     const command = registeredCommands["active-memory"];
 
@@ -674,7 +701,9 @@ describe("active-memory plugin", () => {
         getCurrentConversationBinding: async () => null,
       });
 
-      expect(result.text).toContain("global enable/disable changes require operator.admin");
+      expect(result.text).toContain(
+        "global enable/disable changes require owner or operator.admin",
+      );
     }
 
     expect(api.runtime.config.mutateConfigFile).not.toHaveBeenCalled();
diff --git a/extensions/active-memory/index.ts b/extensions/active-memory/index.ts
@@ -827,12 +827,18 @@ function updateActiveMemoryGlobalEnabledInConfig(
   };
 }
 
-function requiresAdminToMutateActiveMemoryGlobal(gatewayClientScopes?: readonly string[]): boolean {
-  return Array.isArray(gatewayClientScopes) && !gatewayClientScopes.includes("operator.admin");
+function lacksAdminToMutateActiveMemoryGlobal(params: {
+  senderIsOwner?: boolean;
+  gatewayClientScopes?: readonly string[];
+}): boolean {
+  if (Array.isArray(params.gatewayClientScopes)) {
+    return !params.gatewayClientScopes.includes("operator.admin");
+  }
+  return params.senderIsOwner !== true;
 }
 
 const ACTIVE_MEMORY_GLOBAL_MUTATION_ADMIN_REQUIRED_TEXT =
-  "⚠️ /active-memory global enable/disable changes require operator.admin for gateway clients.";
+  "⚠️ /active-memory global enable/disable changes require owner or operator.admin.";
 
 function normalizePluginConfig(
   pluginConfig: unknown,
@@ -3487,6 +3493,7 @@ export default definePluginEntry({
       name: "active-memory",
       description: "Enable, disable, or inspect Active Memory for this session.",
       acceptsArgs: true,
+      exposeSenderIsOwner: true,
       handler: async (ctx) => {
         const tokens = ctx.args?.trim().split(/\s+/).filter(Boolean) ?? [];
         const isGlobal = tokens.includes("--global");
@@ -3501,7 +3508,12 @@ export default definePluginEntry({
               text: `Active Memory: ${isActiveMemoryGloballyEnabled(currentConfig) ? "on" : "off"} globally.`,
             };
           }
-          if (requiresAdminToMutateActiveMemoryGlobal(ctx.gatewayClientScopes)) {
+          if (
+            lacksAdminToMutateActiveMemoryGlobal({
+              senderIsOwner: ctx.senderIsOwner,
+              gatewayClientScopes: ctx.gatewayClientScopes,
+            })
+          ) {
             return {
               text: ACTIVE_MEMORY_GLOBAL_MUTATION_ADMIN_REQUIRED_TEXT,
             };
