fix(cron): allow silent scheduled runs (#95725)

LZY3538 · claude · steipete · web-flow · commit 72aa3f1bcf4c · 2026-07-11T07:38:53.000-07:00
* fix(cron): pass allowEmptyAssistantReplyAsSilent from cron executor Intentionally-silent cron jobs (alert watchers that say nothing unless there is something to report) fail with FailoverError "empty_response" because the allowEmptyAssistantReplyAsSilent flag is only computed for DM/group chat contexts — the cron executor never sets it. Instead of patching the shared CLI runner with a lane substring heuristic, set allowEmptyAssistantReplyAsSilent: true at the cron executor level for both the CLI and embedded runner paths. This: - Owns the silent-empty policy at the correct boundary (the cron executor) - Covers both runner paths uniformly - Does not broaden the shared CLI empty-response guard for non-cron callers Fixes #94224 Co-Authored-By: Claude <noreply@anthropic.com> * test(cron): add regression test for allowEmptyAssistantReplyAsSilent flag propagation Verify that the cron executor passes allowEmptyAssistantReplyAsSilent: true to both runCliAgent and runEmbeddedAgent calls. The embedded test uses mockTexts: [""] to truly exercise empty output, and the CLI test mocks runCliAgent with empty payload text — both scenarios require the flag to avoid empty_response errors on intentionally-silent cron watchers. Co-Authored-By: Claude <noreply@anthropic.com> * refactor(cron): centralize silent reply policy Reuse existing executor suites and keep CLI and embedded cron runners aligned. Co-authored-by: 刘镇业 0668001127 <liu.zhenye@xydigit.com> --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>
diff --git a/src/cron/isolated-agent/run-executor.ts b/src/cron/isolated-agent/run-executor.ts
@@ -277,6 +277,8 @@ export function createCronPromptExecutor(params: {
     resolveFallbackCronSourceDeliveryPlan(params.job, params.resolvedDelivery);
   const sourceReplyDeliveryMode = sourceDelivery.sourceReplyDeliveryMode;
   const messageChannel = sourceDelivery.target.channel ?? params.resolvedDelivery.channel;
+  // Cron prompts may intentionally have nothing to report; both runners must agree on silence.
+  const allowEmptyAssistantReplyAsSilent = true;
   const deliveryTargetRuntimeContext = buildCronDeliveryTargetRuntimeContext({
     resolvedDeliveryOk: params.resolvedDeliveryOk,
     messageToolPromptEnabled: params.messageToolPromptEnabled,
@@ -427,6 +429,7 @@ export function createCronPromptExecutor(params: {
             timeoutMs: params.timeoutMs,
             runId: params.cronSession.sessionEntry.sessionId,
             lane: resolveCronAgentLane(params.lane),
+            allowEmptyAssistantReplyAsSilent,
             cliSessionId: cliSessionBinding?.sessionId,
             cliSessionBinding: guardedCliSessionBinding,
             skillsSnapshot: params.skillsSnapshot,
@@ -541,6 +544,7 @@ export function createCronPromptExecutor(params: {
             : undefined,
           sourceReplyDeliveryMode,
           runId: params.cronSession.sessionEntry.sessionId,
+          allowEmptyAssistantReplyAsSilent,
           requireExplicitMessageTarget: sourceDelivery.messageTool.requireExplicitTarget,
           disableMessageTool: !sourceDelivery.messageTool.enabled,
           forceMessageTool: sourceDelivery.messageTool.force,
diff --git a/src/cron/isolated-agent/run.message-tool-policy.test.ts b/src/cron/isolated-agent/run.message-tool-policy.test.ts
@@ -755,6 +755,7 @@ describe("runCronIsolatedAgentTurn message tool policy", () => {
     expectRecordFields(
       getMockCallArg(runCliAgentMock, 0, 0, "CLI run"),
       {
+        allowEmptyAssistantReplyAsSilent: true,
         messageChannel: "messagechat",
         requireExplicitMessageTarget: true,
       },
diff --git a/src/cron/isolated-agent/run.source-delivery-guard.test.ts b/src/cron/isolated-agent/run.source-delivery-guard.test.ts
@@ -288,6 +288,7 @@ describe("createCronPromptExecutor sourceDelivery guard", () => {
     expect(runEmbeddedAgentMock).toHaveBeenCalledTimes(1);
     const args = getEmbeddedRunArg();
     expect(args.sourceReplyDeliveryMode).toBeUndefined();
+    expect(args.allowEmptyAssistantReplyAsSilent).toBe(true);
     expect(args.requireExplicitMessageTarget).toBe(false);
     expect(args.disableMessageTool).toBe(false);
     expect(args.forceMessageTool).toBe(false);
@@ -308,6 +309,7 @@ describe("createCronPromptExecutor sourceDelivery guard", () => {
     expect(runEmbeddedAgentMock).toHaveBeenCalledTimes(1);
     const args = getEmbeddedRunArg();
     expect(args.sourceReplyDeliveryMode).toBeUndefined();
+    expect(args.allowEmptyAssistantReplyAsSilent).toBe(true);
     expect(args.disableMessageTool).toBe(false);
     expect(args.forceMessageTool).toBe(false);
     expect(args.messageChannel).toBe("messagechat");

Original file line number	Diff line number	Diff line change
`@@ -755,6 +755,7 @@ describe("runCronIsolatedAgentTurn message tool policy", () => {`
`755`	`755`	`expectRecordFields(`
`756`	`756`	`getMockCallArg(runCliAgentMock, 0, 0, "CLI run"),`
`757`	`757`	`{`
	`758`	`+ allowEmptyAssistantReplyAsSilent: true,`
`758`	`759`	`messageChannel: "messagechat",`
`759`	`760`	`requireExplicitMessageTarget: true,`
`760`	`761`	`},`