test(sms): type request mocks

steipete · steipete · commit 720a3cd8ab3b · 2026-05-31T10:16:44.000+01:00
diff --git a/extensions/sms/src/inbound.test.ts b/extensions/sms/src/inbound.test.ts
@@ -2,8 +2,10 @@ import { describe, expect, it, vi } from "vitest";
 import { dispatchSmsInboundEvent, type SmsChannelRuntime } from "./inbound.js";
 import type { ResolvedSmsAccount } from "./types.js";
 
+type SendSmsViaTwilio = typeof import("./twilio.js").sendSmsViaTwilio;
+
 const sendSmsViaTwilio = vi.hoisted(() =>
-  vi.fn(async () => ({ sid: "SM-pair", to: "+15551234567" })),
+  vi.fn<SendSmsViaTwilio>(async () => ({ sid: "SM-pair", to: "+15551234567" })),
 );
 
 vi.mock("./twilio.js", () => ({
diff --git a/extensions/sms/src/twilio.test.ts b/extensions/sms/src/twilio.test.ts
@@ -29,6 +29,11 @@ function createAccount(overrides: Partial<ResolvedSmsAccount> = {}): ResolvedSms
   };
 }
 
+function requireUrlSearchParamsBody(init: RequestInit | undefined): URLSearchParams {
+  expect(init?.body).toBeInstanceOf(URLSearchParams);
+  return init?.body as URLSearchParams;
+}
+
 describe("Twilio SMS helpers", () => {
   it("parses Twilio form bodies and inbound messages", () => {
     const form = parseTwilioFormBody(
@@ -105,7 +110,7 @@ describe("Twilio SMS helpers", () => {
   });
 
   it("sends SMS through Twilio's Messages API", async () => {
-    const fetchImpl = vi.fn(
+    const fetchImpl = vi.fn<typeof fetch>(
       async () =>
         new Response(
           JSON.stringify({
@@ -156,14 +161,14 @@ describe("Twilio SMS helpers", () => {
       authorization: `Basic ${Buffer.from("AC123:secret").toString("base64")}`,
       "content-type": "application/x-www-form-urlencoded",
     });
-    const body = new URLSearchParams(String(init?.body));
+    const body = requireUrlSearchParamsBody(init);
     expect(body.get("From")).toBe("+15557654321");
     expect(body.get("To")).toBe("+15551234567");
     expect(body.get("Body")).toBe("hello");
   });
 
   it("can send through a Twilio Messaging Service SID", async () => {
-    const fetchImpl = vi.fn(
+    const fetchImpl = vi.fn<typeof fetch>(
       async () =>
         new Response(JSON.stringify({ sid: "SM789" }), {
           status: 201,
@@ -193,14 +198,14 @@ describe("Twilio SMS helpers", () => {
     });
 
     const [, init] = fetchImpl.mock.calls[0] ?? [];
-    const body = new URLSearchParams(String(init?.body));
+    const body = requireUrlSearchParamsBody(init);
     expect(body.get("MessagingServiceSid")).toBe("MG123");
     expect(body.get("To")).toBe("+15551234567");
     expect(body.get("Body")).toBe("hello");
   });
 
   it("prefers an explicit from number when both sender options are resolved", async () => {
-    const fetchImpl = vi.fn(
+    const fetchImpl = vi.fn<typeof fetch>(
       async () =>
         new Response(JSON.stringify({ sid: "SM999" }), {
           status: 201,
@@ -230,13 +235,13 @@ describe("Twilio SMS helpers", () => {
     });
 
     const [, init] = fetchImpl.mock.calls[0] ?? [];
-    const body = new URLSearchParams(String(init?.body));
+    const body = requireUrlSearchParamsBody(init);
     expect(body.get("From")).toBe("+15557654321");
     expect(body.get("MessagingServiceSid")).toBeNull();
   });
 
   it("throws structured Twilio errors from JSON error bodies", async () => {
-    const fetchImpl = vi.fn(
+    const fetchImpl = vi.fn<typeof fetch>(
       async () =>
         new Response(
           JSON.stringify({
@@ -266,7 +271,9 @@ describe("Twilio SMS helpers", () => {
   });
 
   it("includes non-JSON Twilio error text in send failures", async () => {
-    const fetchImpl = vi.fn(async () => new Response("upstream unavailable", { status: 503 }));
+    const fetchImpl = vi.fn<typeof fetch>(
+      async () => new Response("upstream unavailable", { status: 503 }),
+    );
 
     await expect(
       sendSmsViaTwilio({
@@ -279,7 +286,7 @@ describe("Twilio SMS helpers", () => {
   });
 
   it("rejects malformed JSON from successful Twilio sends", async () => {
-    const fetchImpl = vi.fn(async () => new Response("not json", { status: 201 }));
+    const fetchImpl = vi.fn<typeof fetch>(async () => new Response("not json", { status: 201 }));
 
     await expect(
       sendSmsViaTwilio({
@@ -304,7 +311,7 @@ describe("Twilio SMS helpers", () => {
   });
 
   it("requires successful Twilio sends to include a Message SID", async () => {
-    const fetchImpl = vi.fn(
+    const fetchImpl = vi.fn<typeof fetch>(
       async () => new Response(JSON.stringify({ status: "queued" }), { status: 201 }),
     );
 
