Skip to content

Commit 715a994

Browse files
committed
fix(gateway): identify failed terminal persistence
1 parent 6b5b399 commit 715a994

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

src/gateway/server-chat.agent-events.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2540,8 +2540,9 @@ describe("agent event handler", () => {
25402540
updatedAt: 2_100,
25412541
abortedLastRun: false,
25422542
});
2543+
expect(logErrorMock).toHaveBeenCalledTimes(1);
25432544
expect(logErrorMock).toHaveBeenCalledWith(
2544-
"gateway: failed to persist terminal session lifecycle event for run run-failed-write: Error: disk full sk-abc…3456",
2545+
"gateway: terminal session persistence failed session=session-failed-write run=run-failed-write error=Error: disk full sk-abc…3456",
25452546
);
25462547
expect(markTrackedRunTerminalPersisted).not.toHaveBeenCalled();
25472548
});

src/gateway/server-chat.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,7 @@ export function createAgentEventHandler({
719719
})
720720
.catch((err: unknown) => {
721721
logError(
722-
`gateway: failed to persist terminal session lifecycle event for run ${evt.runId}: ${formatForLog(err)}`,
722+
`gateway: terminal session persistence failed session=${formatForLog(sessionKey)} run=${formatForLog(evt.runId)} error=${formatForLog(err)}`,
723723
);
724724
// Persistence recovery remains tracked by the controller entry, but
725725
// subscribers still need a terminal projection instead of hanging.

0 commit comments

Comments
 (0)