fix(gateway): filter NO_REPLY messages from chat history endpoint

SidQin-cyber · SidQin-cyber · commit 70d0f85e8e18 · 2026-02-26T14:29:30.000+08:00
The streaming path (emitChatDelta/emitChatFinal) already suppresses assistant messages containing NO_REPLY tokens, but the chat.history endpoint returned them unfiltered. When users refresh webchat or open a new connection, historical NO_REPLY messages appeared in the UI. Add extractAssistantText() to pull text from various message formats and filter out matching messages in sanitizeChatHistoryMessages(), bringing the history path in line with the streaming path. Closes #27238
diff --git a/src/gateway/server-methods/chat.ts b/src/gateway/server-methods/chat.ts
@@ -10,6 +10,7 @@ import type { MsgContext } from "../../auto-reply/templating.js";
 import { createReplyPrefixOptions } from "../../channels/reply-prefix.js";
 import { resolveSessionFilePath } from "../../config/sessions.js";
 import { resolveSendPolicy } from "../../sessions/send-policy.js";
+import { isSilentReplyText } from "../../auto-reply/tokens.js";
 import {
   stripInlineDirectiveTagsForDisplay,
   stripInlineDirectiveTagsFromMessageForDisplay,
@@ -185,16 +186,41 @@ function sanitizeChatHistoryMessage(message: unknown): { message: unknown; chang
   return { message: changed ? entry : message, changed };
 }
 
+function extractAssistantText(message: unknown): string | undefined {
+  if (!message || typeof message !== "object") return undefined;
+  const entry = message as Record<string, unknown>;
+  if (entry.role !== "assistant") return undefined;
+  if (typeof entry.content === "string") return entry.content;
+  if (Array.isArray(entry.content)) {
+    const parts = entry.content
+      .filter(
+        (b: unknown): b is Record<string, unknown> =>
+          !!b && typeof b === "object" && (b as Record<string, unknown>).type === "text",
+      )
+      .map((b) => b.text)
+      .filter((t): t is string => typeof t === "string");
+    return parts.length > 0 ? parts.join("") : undefined;
+  }
+  if (typeof entry.text === "string") return entry.text;
+  return undefined;
+}
+
 function sanitizeChatHistoryMessages(messages: unknown[]): unknown[] {
   if (messages.length === 0) {
     return messages;
   }
   let changed = false;
-  const next = messages.map((message) => {
+  const next: unknown[] = [];
+  for (const message of messages) {
     const res = sanitizeChatHistoryMessage(message);
     changed ||= res.changed;
-    return res.message;
-  });
+    const text = extractAssistantText(res.message);
+    if (text !== undefined && isSilentReplyText(text)) {
+      changed = true;
+      continue;
+    }
+    next.push(res.message);
+  }
   return changed ? next : messages;
 }
 
