fix(browser): reject non-page json new targets (#104129)

Leon-SK668 · steipete · web-flow · commit 7027d2c22728 · 2026-07-11T16:58:43.000-07:00
* fix(browser): reject non-page json new targets

* fix(browser): adopt only validated raw CDP targets

---------

Co-authored-by: Peter Steinberger &lt;steipete@gmail.com&gt;
diff --git a/extensions/browser/src/browser/server-context.remote-profile-tab-ops.fallback.test.ts b/extensions/browser/src/browser/server-context.remote-profile-tab-ops.fallback.test.ts
@@ -181,6 +181,44 @@ describe("browser remote profile fallback and attachOnly behavior", () => {
     await expect(remote.openTab("about:blank")).rejects.toBeInstanceOf(
       deps.BrowserCdpEndpointBlockedError,
     );
+    expect(state.profiles.get("remote")?.lastTargetId).not.toBe("T_BLOCKED");
+  });
+
+  it.each([
+    {
+      id: "WORKER",
+      title: "Worker",
+      url: "https://example.com/worker.js",
+      type: "worker",
+    },
+    {
+      id: "INTERNAL",
+      title: "Settings",
+      url: "chrome://settings/",
+      type: "page",
+    },
+  ])("rejects non-selectable $type target $id returned by raw tab creation", async (created) => {
+    vi.spyOn(deps.pwAiModule, "getPwAiModule").mockResolvedValue(null);
+    vi.spyOn(deps.cdpModule, "createTargetViaCdp").mockRejectedValue(
+      new Error("Target.createTarget unavailable"),
+    );
+    const fetchMock = vi.fn(async (url: unknown) => {
+      const u = String(url);
+      if (!u.includes("/json/new")) {
+        throw new Error(`unexpected fetch: ${u}`);
+      }
+      return {
+        ok: true,
+        json: async () => ({
+          ...created,
+          webSocketDebuggerUrl: `wss://1.1.1.1:9222/devtools/page/${created.id}`,
+        }),
+      } as unknown as Response;
+    });
+    const { state, remote } = deps.createRemoteRouteHarness(fetchMock);
+
+    await expect(remote.openTab("https://example.com")).rejects.toThrow(/non-selectable target/);
+    expect(state.profiles.get("remote")?.lastTargetId).not.toBe(created.id);
   });
 
   it("fails closed for remote tab opens in strict mode without Playwright", async () => {
diff --git a/extensions/browser/src/browser/server-context.tab-ops.ts b/extensions/browser/src/browser/server-context.tab-ops.ts
@@ -442,8 +442,10 @@ export function createProfileTabOps({ profile, state, runtime }: TabOpsDeps): Pr
     if (!created.id) {
       throw new Error("Failed to open tab (missing id)");
     }
-    runtime.lastTargetId = created.id;
     const resolvedUrl = created.url ?? url;
+    if (!isSelectableCdpBrowserTarget({ url: resolvedUrl, type: created.type })) {
+      throw new Error("Failed to open tab (non-selectable target)");
+    }
     await assertBrowserNavigationResultAllowed({ url: resolvedUrl, ...ssrfPolicyOpts });
     const wsUrl = normalizeWsUrl(created.webSocketDebuggerUrl, profile.cdpUrl);
     if (wsUrl) {
@@ -452,6 +454,9 @@ export function createProfileTabOps({ profile, state, runtime }: TabOpsDeps): Pr
         configuredUrl: profile.cdpUrl,
       });
     }
+    // Adopt only fully validated targets. A failed open must not make a
+    // blocked or non-page target sticky for the next implicit action.
+    runtime.lastTargetId = created.id;
     triggerManagedTabLimit(created.id, opts);
     return assignTabAlias({
       profileState: runtime,
