fix(memory-core): keep qmd mcporter cause generic (no raw stdout leak via formatErrorMessage)

miorbnli · claude · miorbnli · commit 6eb1289c47a8 · 2026-07-03T08:45:48.000+08:00
formatErrorMessage walks the .cause chain into the user-visible path.
Keeping the JSON.parse SyntaxError on .cause leaked its embedded raw
stdout snippet through formatErrorMessage even with a generic message.
Give the cause a generic message too; the raw snippet no longer reaches
the user.

Co-Authored-By: Claude &lt;noreply@anthropic.com&gt;
diff --git a/extensions/memory-core/src/memory/qmd-manager.ts b/extensions/memory-core/src/memory/qmd-manager.ts
@@ -2722,15 +2722,17 @@ export class QmdMemoryManager implements MemorySearchManager {
     let parsedUnknown: unknown;
     try {
       parsedUnknown = JSON.parse(result.stdout);
-    } catch (err) {
+    } catch {
       // mcporter (subprocess) can emit non-JSON stdout when output is truncated
       // by maxOutputChars, a daemon warning bleeds onto stdout, or the CLI is
-      // killed early. Wrap the SyntaxError so callers get a typed domain error.
-      // The message stays generic on purpose: JSON.parse's SyntaxError message
-      // embeds a snippet of the raw input, which is surfaced before session
-      // visibility filtering and could leak sensitive content. The original
-      // error is preserved as `cause` for developer diagnostics only.
-      throw new Error("qmd mcporter returned non-JSON stdout", { cause: err });
+      // killed early. Wrap the failure so callers get a typed domain error.
+      // The thrown Error and its cause both carry generic messages on purpose:
+      // errors.ts formatErrorMessage walks the .cause chain into the user-visible
+      // path, so the JSON.parse SyntaxError (whose message embeds a raw stdout
+      // snippet) must not sit on .cause, or that snippet leaks to the user.
+      throw new Error("qmd mcporter returned non-JSON stdout", {
+        cause: new Error("mcporter stdout was not valid JSON"),
+      });
     }
     const parsedRecord = asRecord(parsedUnknown);
     const structuredContent = parsedRecord ? asRecord(parsedRecord.structuredContent) : null;
