fix(sdk): keep surface budgets tight

vincentkoc · vincentkoc · commit 6df67285df48 · 2026-06-25T02:18:07.000+08:00
diff --git a/scripts/plugin-sdk-surface-report.mjs b/scripts/plugin-sdk-surface-report.mjs
@@ -202,8 +202,8 @@ let publicDeprecatedExportsByEntrypointBudget;
 try {
   budgets = {
     publicEntrypoints: readBudgetEnv("OPENCLAW_PLUGIN_SDK_MAX_PUBLIC_ENTRYPOINTS", 322),
-    publicExports: readBudgetEnv("OPENCLAW_PLUGIN_SDK_MAX_PUBLIC_EXPORTS", 10411),
-    publicFunctionExports: readBudgetEnv("OPENCLAW_PLUGIN_SDK_MAX_PUBLIC_FUNCTION_EXPORTS", 5251),
+    publicExports: readBudgetEnv("OPENCLAW_PLUGIN_SDK_MAX_PUBLIC_EXPORTS", 10381),
+    publicFunctionExports: readBudgetEnv("OPENCLAW_PLUGIN_SDK_MAX_PUBLIC_FUNCTION_EXPORTS", 5210),
     publicDeprecatedExports: readBudgetEnv(
       "OPENCLAW_PLUGIN_SDK_MAX_PUBLIC_DEPRECATED_EXPORTS",
       3247,
diff --git a/test/scripts/plugin-sdk-surface-report.test.ts b/test/scripts/plugin-sdk-surface-report.test.ts
@@ -1,5 +1,6 @@
 // Plugin Sdk Surface Report tests cover plugin sdk surface report script behavior.
 import { spawnSync } from "node:child_process";
+import { readFileSync } from "node:fs";
 import { describe, expect, it } from "vitest";
 
 function runSurfaceReport(env: Record<string, string>) {
@@ -18,13 +19,32 @@ function readCurrentPublicFunctionExportCount() {
   expect(result.status).toBe(0);
   expect(result.stderr).toBe("");
 
-  const match = /public package SDK entrypoints:[\s\S]*?\n  callable exports: (\d+)/u.exec(
-    result.stdout,
+  return parseCurrentPublicCounts(result.stdout).functionExports;
+}
+
+function parseCurrentPublicCounts(stdout: string) {
+  const match = /public package SDK entrypoints:[\s\S]*?\n  exports: (\d+)\n  callable exports: (\d+)/u
+    .exec(stdout);
+  if (match === null || match[1] === undefined || match[2] === undefined) {
+    throw new Error("failed to read current public export counts");
+  }
+  return {
+    exports: Number(match[1]),
+    functionExports: Number(match[2]),
+  };
+}
+
+function readDefaultBudget(envName: string): number {
+  const source = readFileSync("scripts/plugin-sdk-surface-report.mjs", "utf8");
+  const match = new RegExp(
+    `readBudgetEnv\\("${envName}",\\s*(\\d+)\\)`,
+    "u",
   );
-  if (match === null || match[1] === undefined) {
-    throw new Error("failed to read current public function export count");
+  const result = match.exec(source);
+  if (result === null || result[1] === undefined) {
+    throw new Error(`failed to read default budget for ${envName}`);
   }
-  return Number(match[1]);
+  return Number(result[1]);
 }
 
 describe("plugin SDK surface report", () => {
@@ -95,6 +115,18 @@ describe("plugin SDK surface report", () => {
     expect(result.stderr).toBe("");
   });
 
+  it("keeps default public budgets tight to the current source surface", () => {
+    const result = runSurfaceReport({});
+    expect(result.status).toBe(0);
+    expect(result.stderr).toBe("");
+
+    const counts = parseCurrentPublicCounts(result.stdout);
+    expect(readDefaultBudget("OPENCLAW_PLUGIN_SDK_MAX_PUBLIC_EXPORTS")).toBe(counts.exports);
+    expect(readDefaultBudget("OPENCLAW_PLUGIN_SDK_MAX_PUBLIC_FUNCTION_EXPORTS")).toBe(
+      counts.functionExports,
+    );
+  });
+
   it("keeps generated package declarations out of source surface counts", () => {
     const budget = readCurrentPublicFunctionExportCount();
     const result = runSurfaceReport({
