fix(scripts): reject short flag docker package values

vincentkoc · vincentkoc · commit 6daf9307e0b9 · 2026-06-21T21:24:30.000+02:00
diff --git a/scripts/package-openclaw-for-docker.mjs b/scripts/package-openclaw-for-docker.mjs
@@ -67,14 +67,14 @@ function resolveTimeoutMs(envName, defaultValue) {
 
 function readOptionValue(argv, index, optionName) {
   const value = argv[index + 1];
-  if (value === undefined || value === "" || value.startsWith("--")) {
+  if (value === undefined || value === "" || value.startsWith("-")) {
     throw new Error(`${optionName} requires a value`);
   }
   return value;
 }
 
 function readEqualsOptionValue(value, optionName) {
-  if (value === "" || value.startsWith("--")) {
+  if (value === "" || value.startsWith("-")) {
     throw new Error(`${optionName} requires a value`);
   }
   return value;
diff --git a/test/e2e/qa-lab/runtime/package-openclaw-for-docker.e2e.test.ts b/test/e2e/qa-lab/runtime/package-openclaw-for-docker.e2e.test.ts
@@ -98,7 +98,9 @@ describe("package-openclaw-for-docker", () => {
     for (const flag of ["--output-dir", "--output-name", "--source-dir"]) {
       expect(() => parseArgs([flag])).toThrow(`${flag} requires a value`);
       expect(() => parseArgs([flag, "--skip-build"])).toThrow(`${flag} requires a value`);
+      expect(() => parseArgs([flag, "-h"])).toThrow(`${flag} requires a value`);
       expect(() => parseArgs([`${flag}=`])).toThrow(`${flag} requires a value`);
+      expect(() => parseArgs([`${flag}=-h`])).toThrow(`${flag} requires a value`);
     }
   });
 

Original file line number	Diff line number	Diff line change
`@@ -67,14 +67,14 @@ function resolveTimeoutMs(envName, defaultValue) {`
`67`	`67`
`68`	`68`	`function readOptionValue(argv, index, optionName) {`
`69`	`69`	`const value = argv[index + 1];`
`70`		`- if (value === undefined \|\| value === "" \|\| value.startsWith("--")) {`
	`70`	`+ if (value === undefined \|\| value === "" \|\| value.startsWith("-")) {`
`71`	`71`	throw new Error(`${optionName} requires a value`);
`72`	`72`	`}`
`73`	`73`	`return value;`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`function readEqualsOptionValue(value, optionName) {`
`77`		`- if (value === "" \|\| value.startsWith("--")) {`
	`77`	`+ if (value === "" \|\| value.startsWith("-")) {`
`78`	`78`	throw new Error(`${optionName} requires a value`);
`79`	`79`	`}`
`80`	`80`	`return value;`
Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,9 @@ describe("package-openclaw-for-docker", () => {`
`98`	`98`	`for (const flag of ["--output-dir", "--output-name", "--source-dir"]) {`
`99`	`99`	expect(() => parseArgs([flag])).toThrow(`${flag} requires a value`);
`100`	`100`	expect(() => parseArgs([flag, "--skip-build"])).toThrow(`${flag} requires a value`);
	`101`	+ expect(() => parseArgs([flag, "-h"])).toThrow(`${flag} requires a value`);
`101`	`102`	expect(() => parseArgs([`${flag}=`])).toThrow(`${flag} requires a value`);
	`103`	+ expect(() => parseArgs([`${flag}=-h`])).toThrow(`${flag} requires a value`);
`102`	`104`	`}`
`103`	`105`	`});`
`104`	`106`