Plugins: drop duplicate callback replay artifacts

huntharo · huntharo · commit 6d7b32b1849c · 2026-03-17T13:09:58.000-04:00
diff --git a/extensions/lobster/src/lobster-tool.test.ts b/extensions/lobster/src/lobster-tool.test.ts
@@ -53,7 +53,6 @@ function fakeApi(overrides: Partial<OpenClawPluginApi> = {}): OpenClawPluginApi
     registerHook() {},
     registerHttpRoute() {},
     registerCommand() {},
-    onConversationBindingResolved() {},
     registerContextEngine() {},
     on() {},
     resolvePath: (p) => p,
diff --git a/src/auto-reply/reply/route-reply.test.ts b/src/auto-reply/reply/route-reply.test.ts
@@ -101,7 +101,6 @@ const createRegistry = (channels: PluginRegistry["channels"]): PluginRegistry =>
   services: [],
   conversationBindingResolvedHandlers: [],
   diagnostics: [],
-  conversationBindingResolvedHandlers: [],
 });
 
 const createMSTeamsOutbound = (): ChannelOutboundAdapter => ({
diff --git a/src/gateway/server-plugins.test.ts b/src/gateway/server-plugins.test.ts
@@ -60,7 +60,6 @@ const createRegistry = (diagnostics: PluginDiagnostic[]): PluginRegistry => ({
   services: [],
   conversationBindingResolvedHandlers: [],
   diagnostics,
-  conversationBindingResolvedHandlers: [],
 });
 
 type ServerPluginsModule = typeof import("./server-plugins.js");
diff --git a/src/gateway/test-helpers.mocks.ts b/src/gateway/test-helpers.mocks.ts
@@ -157,7 +157,6 @@ const createStubPluginRegistry = (): PluginRegistry => ({
   commands: [],
   conversationBindingResolvedHandlers: [],
   diagnostics: [],
-  conversationBindingResolvedHandlers: [],
 });
 
 const hoisted = vi.hoisted(() => ({
diff --git a/src/plugins/conversation-binding.ts b/src/plugins/conversation-binding.ts
@@ -531,7 +531,7 @@ function decodeCustomIdValue(value: string): string {
 
 export function buildPluginBindingApprovalCustomId(
   approvalId: string,
-  decision: PluginBindingApprovalDecisionWithDeny,
+  decision: PluginBindingApprovalDecision,
 ): string {
   const decisionCode = decision === "allow-once" ? "o" : decision === "allow-always" ? "a" : "d";
   return `${PLUGIN_BINDING_CUSTOM_ID_PREFIX}:${encodeCustomIdValue(approvalId)}:${decisionCode}`;
diff --git a/src/plugins/registry.ts b/src/plugins/registry.ts
@@ -792,20 +792,6 @@ export function createPluginRegistry(registryParams: PluginRegistryParams) {
     });
   };
 
-  const registerConversationBindingResolvedHandler = (
-    record: PluginRecord,
-    handler: (event: PluginConversationBindingResolvedEvent) => void | Promise<void>,
-  ) => {
-    registry.conversationBindingResolvedHandlers.push({
-      pluginId: record.id,
-      pluginName: record.name,
-      pluginRoot: record.rootDir,
-      handler,
-      source: record.source,
-      rootDir: record.rootDir,
-    });
-  };
-
   const registerTypedHook = <K extends PluginHookName>(
     record: PluginRecord,
     hookName: K,
diff --git a/src/test-utils/channel-plugins.ts b/src/test-utils/channel-plugins.ts
@@ -37,7 +37,6 @@ export const createTestRegistry = (channels: TestChannelRegistration[] = []): Pl
   commands: [],
   conversationBindingResolvedHandlers: [],
   diagnostics: [],
-  conversationBindingResolvedHandlers: [],
 });
 
 export const createChannelTestPluginBase = (params: {
