fix(workspaces): keep operations widget helpers private

Eva · Eva · commit 6b5c0c14a606 · 2026-07-13T17:56:30.000+07:00
diff --git a/ui/src/lib/workspace/widgets/agent-status.ts b/ui/src/lib/workspace/widgets/agent-status.ts
@@ -19,7 +19,7 @@ type AgentStatusRowModel = {
   progress: number | null;
 };
 
-export type AgentStatusModel = {
+type AgentStatusModel = {
   rows: AgentStatusRowModel[];
   activeCount: number;
   total: number;
@@ -49,7 +49,7 @@ function rowProgress(row: Record<string, unknown>): number | null {
   return Math.min(1, Math.max(0, used / budget));
 }
 
-export function mapAgentStatus(widget: WorkspaceWidget, value: unknown): AgentStatusModel {
+function mapAgentStatus(widget: WorkspaceWidget, value: unknown): AgentStatusModel {
   const raw = Array.isArray(value)
     ? value
     : isRecord(value) && Array.isArray(value.sessions)
diff --git a/ui/src/lib/workspace/widgets/approvals.ts b/ui/src/lib/workspace/widgets/approvals.ts
@@ -16,9 +16,9 @@ import {
 
 const DEFAULT_LIMIT = 8;
 
-export type ApprovalsModel = { items: PendingApprovalItem[]; total: number };
+type ApprovalsModel = { items: PendingApprovalItem[]; total: number };
 
-export function toWidgetApprovalDecision(decision: ApprovalDecision): "approved" | "rejected" {
+function toWidgetApprovalDecision(decision: ApprovalDecision): "approved" | "rejected" {
   return decision === "approve" ? "approved" : "rejected";
 }
 
@@ -40,7 +40,7 @@ export function buildWidgetApprovalsSource(
   };
 }
 
-export function mapApprovals(
+function mapApprovals(
   widget: WorkspaceWidget,
   source: ApprovalsWidgetSource | undefined,
 ): ApprovalsModel {
diff --git a/ui/src/lib/workspace/widgets/widgets.test.ts b/ui/src/lib/workspace/widgets/widgets.test.ts
@@ -7,13 +7,8 @@ import { render } from "lit";
 import { describe, expect, it } from "vitest";
 import type { WorkspaceWidget } from "../types.ts";
 import { mapActivity, renderActivity } from "./activity.ts";
-import { mapAgentStatus, renderAgentStatus } from "./agent-status.ts";
-import {
-  buildWidgetApprovalsSource,
-  mapApprovals,
-  renderApprovals,
-  toWidgetApprovalDecision,
-} from "./approvals.ts";
+import { renderAgentStatus } from "./agent-status.ts";
+import { buildWidgetApprovalsSource, renderApprovals } from "./approvals.ts";
 import { mapCron, renderCron } from "./cron.ts";
 import { evaluateEmbedUrl, renderIframeEmbed } from "./iframe-embed.ts";
 import { mapInstances, renderInstances } from "./instances.ts";
@@ -48,25 +43,24 @@ const STRICT_EMBED: BuiltinWidgetContext = {
 
 describe("agent-status mapping", () => {
   it("maps only keyed sessions and clamps goal progress", () => {
-    const model = mapAgentStatus(widget({ props: { limit: 2 } }), {
-      sessions: [
-        {
-          key: "agent:one",
-          displayName: "One",
-          hasActiveRun: true,
-          goal: { objective: "Ship the workspace", tokensUsed: 125, tokenBudget: 100 },
-        },
-        { key: "agent:two", status: "idle" },
-        { displayName: "missing key" },
-      ],
-    });
-    expect(model).toMatchObject({ activeCount: 1, total: 2 });
-    expect(model.rows[0]).toMatchObject({
-      key: "agent:one",
-      active: true,
-      task: "Ship the workspace",
-      progress: 1,
-    });
+    const container = renderToContainer(
+      renderAgentStatus(widget({ props: { limit: 2 } }), {
+        sessions: [
+          {
+            key: "agent:one",
+            displayName: "One",
+            hasActiveRun: true,
+            goal: { objective: "Ship the workspace", tokensUsed: 125, tokenBudget: 100 },
+          },
+          { key: "agent:two", status: "idle" },
+          { displayName: "missing key" },
+        ],
+      }),
+    );
+    expect(container.querySelectorAll(".workspace-list__row")).toHaveLength(2);
+    expect(container.textContent).toContain("Ship the workspace");
+    expect(container.textContent).toContain("100");
+    expect(container.textContent).not.toContain("missing key");
   });
 
   it("renders accessible status text and an empty state", () => {
@@ -102,7 +96,6 @@ describe("approvals mapping", () => {
     ]);
     source.onDecide(source.pending[0]!, "reject");
     expect(decisions).toEqual([["pending", "rejected"]]);
-    expect(toWidgetApprovalDecision("approve")).toBe("approved");
   });
 
   it("limits rows and renders explicit approval controls", () => {
@@ -113,13 +106,13 @@ describe("approvals mapping", () => {
       ],
       onDecide: () => undefined,
     };
-    expect(mapApprovals(widget({ props: { limit: 1 } }), source)).toMatchObject({ total: 2 });
     const container = renderToContainer(
       renderApprovals(widget({ props: { limit: 1 } }), undefined, {
         ...STRICT_EMBED,
         approvals: source,
       }),
     );
+    expect(container.querySelectorAll(".workspace-list__row")).toHaveLength(1);
     expect(container.querySelectorAll("button")).toHaveLength(2);
     expect(container.textContent).toContain("Approve");
     expect(container.textContent).toContain("Reject");
