fix(ci): address review sweep regressions

steipete · steipete · commit 6a482584ee62 · 2026-05-24T03:55:49.000+01:00
diff --git a/extensions/signal/src/client-adapter.ts b/extensions/signal/src/client-adapter.ts
@@ -62,7 +62,7 @@ function waitForNativePreferenceGrace(
   return new Promise((resolve) => {
     const timer = setTimeout(() => resolve({ ok: false }), NATIVE_PREFERENCE_GRACE_MS);
     timer.unref?.();
-    nativeResultPromise.then((result) => {
+    void nativeResultPromise.then((result) => {
       clearTimeout(timer);
       resolve(result);
     });
diff --git a/extensions/twitch/src/twitch-client.ts b/extensions/twitch/src/twitch-client.ts
@@ -49,7 +49,12 @@ export class TwitchClientManager {
         );
         this.logger.info(`Added user ${userId} to RefreshingAuthProvider for ${account.username}`);
       } catch (err) {
-        throw new Error(`Failed to add user to RefreshingAuthProvider: ${formatErrorMessage(err)}`);
+        throw new Error(
+          `Failed to add user to RefreshingAuthProvider: ${formatErrorMessage(err)}`,
+          {
+            cause: err,
+          },
+        );
       }
 
       authProvider.onRefresh((userId, token) => {
diff --git a/src/cli/completion-cli.ts b/src/cli/completion-cli.ts
@@ -49,7 +49,7 @@ function fishWords(values: readonly string[]): string {
 
 function fishOptionFlags(options: Command["options"], wantsValue: boolean): string[] {
   return options.flatMap((option) => {
-    if (Boolean(option.required || option.optional) !== wantsValue) {
+    if ((option.required || option.optional) !== wantsValue) {
       return [];
     }
     return splitOptionFlags(option.flags).filter((flag) => flag.startsWith("-"));
diff --git a/src/cli/cron-cli/register.cron-edit.ts b/src/cli/cron-cli/register.cron-edit.ts
@@ -254,15 +254,17 @@ export function registerCronEditCommand(cron: Command) {
             typeof opts.channel === "string" || typeof opts.to === "string" || hasDeliveryThreadId;
           const hasDeliveryAccount = typeof opts.account === "string";
           const hasBestEffort = typeof opts.bestEffortDeliver === "boolean";
-          const hasAgentTurnPatch =
+          const hasAgentTurnPayloadField =
             typeof opts.message === "string" ||
             Boolean(model) ||
             Boolean(thinking) ||
             hasTimeoutSeconds ||
             typeof opts.lightContext === "boolean" ||
             typeof opts.tools === "string" ||
             Array.isArray(opts.tools) ||
-            opts.clearTools ||
+            opts.clearTools;
+          const hasAgentTurnPatch =
+            hasAgentTurnPayloadField ||
             hasDeliveryModeFlag ||
             hasDeliveryTarget ||
             hasDeliveryAccount ||
@@ -299,8 +301,11 @@ export function registerCronEditCommand(cron: Command) {
             const delivery: Record<string, unknown> = {};
             if (hasDeliveryModeFlag) {
               delivery.mode = opts.announce || opts.deliver === true ? "announce" : "none";
-            } else if (opts.bestEffortDeliver === true) {
-              // Back-compat: toggling best-effort alone has historically implied announce mode.
+            } else if (
+              opts.bestEffortDeliver === true ||
+              (hasAgentTurnPayloadField && hasBestEffort)
+            ) {
+              // Back-compat: best-effort true and payload edits historically implied announce mode.
               delivery.mode = "announce";
             }
             if (typeof opts.channel === "string") {

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ function fishWords(values: readonly string[]): string {`
`49`	`49`
`50`	`50`	`function fishOptionFlags(options: Command["options"], wantsValue: boolean): string[] {`
`51`	`51`	`return options.flatMap((option) => {`
`52`		`- if (Boolean(option.required \|\| option.optional) !== wantsValue) {`
	`52`	`+ if ((option.required \|\| option.optional) !== wantsValue) {`
`53`	`53`	`return [];`
`54`	`54`	`}`
`55`	`55`	`return splitOptionFlags(option.flags).filter((flag) => flag.startsWith("-"));`