fix(googlechat): sanitize internal tool-trace lines from outbound text (#90684) (#95084)

jailbirt · claude · openclaw-clownfish[bot] · web-flow · commit 696c62400803 · 2026-06-22T13:37:06.000+08:00
* fix(googlechat): sanitize internal tool-trace lines from outbound text (#90684) Google Chat ran only sanitizeForPlainText() on outbound text, so internal assistant trace lines leaked to users — most visibly the `⚠️ 🛠️ <command> (agent) failed` banner emitted for benign non-zero shell exits (e.g. a grep with no match, exit 1). The turn succeeds but the user gets an alarming "failed" message. Apply sanitizeAssistantVisibleText() before sanitizeForPlainText() in the googlechat outbound sanitizeText hook, mirroring Discord and WhatsApp. The hook runs pre-chunking in the shared deliver path, covering all text sends. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(googlechat): sanitize internal tool-trace lines from outbound text (#90684) --------- Co-authored-by: Claude Code <claude@anthropic.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: openclaw-clownfish[bot] <280122609+openclaw-clownfish[bot]@users.noreply.github.com>
diff --git a/extensions/googlechat/src/channel.adapters.ts b/extensions/googlechat/src/channel.adapters.ts
@@ -23,6 +23,7 @@ import { createLazyRuntimeNamedExport } from "openclaw/plugin-sdk/lazy-runtime";
 import type { OutboundMediaLoadOptions } from "openclaw/plugin-sdk/outbound-media";
 import type { ReplyPayload } from "openclaw/plugin-sdk/reply-runtime";
 import { normalizeOptionalString } from "openclaw/plugin-sdk/string-coerce-runtime";
+import { sanitizeAssistantVisibleText } from "openclaw/plugin-sdk/text-chunking";
 import { shouldSuppressGoogleChatManualExecApprovalFollowupPayload } from "./approval-card-actions.js";
 import { formatGoogleChatAllowFromEntry } from "./channel-base.js";
 import {
@@ -194,7 +195,11 @@ export const googlechatOutboundAdapter = {
     chunker: chunkTextForOutbound,
     chunkerMode: "markdown" as const,
     textChunkLimit: 4000,
-    sanitizeText: ({ text }: { text: string }) => sanitizeForPlainText(text),
+    // Google Chat's plain-text pass does not remove assistant scaffolding.
+    // Run the canonical delivery sanitizer first so internal tool traces are
+    // dropped before channel formatting.
+    sanitizeText: ({ text }: { text: string }) =>
+      sanitizeForPlainText(sanitizeAssistantVisibleText(text)),
     normalizePayload: ({ payload }: { payload: ReplyPayload }) =>
       shouldSuppressGoogleChatManualExecApprovalFollowupPayload(payload) ? null : payload,
     resolveTarget: ({ to }: { to?: string }) => {
diff --git a/extensions/googlechat/src/channel.test.ts b/extensions/googlechat/src/channel.test.ts
@@ -843,3 +843,21 @@ describe("googlechatPlugin security", () => {
     );
   });
 });
+
+describe("googlechatPlugin outbound sanitizeText", () => {
+  const sanitizeText = googlechatOutboundAdapter.base.sanitizeText;
+
+  it("strips internal tool-trace failure banners from outbound text (#90684)", () => {
+    const text =
+      "Visible answer.\n" + "⚠️ 🛠️ `run openclaw definitely-not-a-real-subcommand (agent)` failed";
+    const out = sanitizeText({ text });
+    expect(out).toBe("Visible answer.");
+    expect(out).not.toContain("failed");
+    expect(out).not.toContain("🛠️");
+  });
+
+  it("preserves ordinary assistant prose untouched", () => {
+    const text = "El pipeline tiene 3 deals abiertos por USD 12.000.";
+    expect(sanitizeText({ text })).toBe(text);
+  });
+});
