fix(policy): fail stale monitored coverage paths

giodl73-repo · giodl73-repo · commit 689734541b7a · 2026-06-26T17:56:52.000-07:00
diff --git a/scripts/check-policy-config-coverage.ts b/scripts/check-policy-config-coverage.ts
@@ -42,6 +42,10 @@ type ClassifiedEntry = {
   readonly classification?: CoverageClassification;
 };
 
+type UnmatchedMonitoredPattern = {
+  readonly pattern: string;
+};
+
 const args = new Set(process.argv.slice(2));
 const json = args.has("--json");
 const check = args.has("--check");
@@ -67,6 +71,17 @@ const monitoredEntries = flattenConfigDocBaselineEntries(baseline)
   .filter((entry) => !entry.hasChildren)
   .filter((entry) => matchesAny(config.monitored, entry.path))
   .toSorted((left, right) => left.path.localeCompare(right.path));
+const leafEntries = flattenConfigDocBaselineEntries(baseline).filter((entry) => !entry.hasChildren);
+const unmatchedMonitored = config.monitored
+  .filter(
+    (pattern) =>
+      !leafEntries.some((entry) => pathMatchesPattern(pattern, entry.path)) &&
+      !config.classifications.some(
+        (item) => item.allowNoSchemaPath === true && pathMatchesPattern(item.pattern, pattern),
+      ),
+  )
+  .map((pattern) => ({ pattern }))
+  .toSorted((left, right) => left.pattern.localeCompare(right.pattern));
 
 const classified: ClassifiedEntry[] = monitoredEntries.map((entry) => ({
   path: entry.path,
@@ -87,10 +102,11 @@ if (json) {
   console.log(
     JSON.stringify(
       {
-        ok: unclassified.length === 0 && stale.length === 0,
+        ok: unclassified.length === 0 && stale.length === 0 && unmatchedMonitored.length === 0,
         monitoredPaths: monitoredEntries.length,
         counts: summaryCounts,
         unclassified,
+        unmatchedMonitored,
         stale,
       },
       null,
@@ -102,19 +118,21 @@ if (json) {
     monitoredPaths: monitoredEntries.length,
     counts: summaryCounts,
     unclassified,
+    unmatchedMonitored,
     stale,
     classified,
   });
 }
 
-if (check && (unclassified.length > 0 || stale.length > 0)) {
+if (check && (unclassified.length > 0 || stale.length > 0 || unmatchedMonitored.length > 0)) {
   process.exit(1);
 }
 
 function printTextReport(input: {
   readonly monitoredPaths: number;
   readonly counts: Record<string, number>;
   readonly unclassified: readonly ClassifiedEntry[];
+  readonly unmatchedMonitored: readonly UnmatchedMonitoredPattern[];
   readonly stale: readonly CoverageClassification[];
   readonly classified: readonly ClassifiedEntry[];
 }): void {
@@ -137,6 +155,15 @@ function printTextReport(input: {
     console.log("\nNo unclassified monitored config paths.");
   }
 
+  if (input.unmatchedMonitored.length > 0) {
+    console.log("\nMonitored patterns with no matching config paths:");
+    for (const entry of input.unmatchedMonitored) {
+      console.log(`  - ${entry.pattern}`);
+    }
+  } else {
+    console.log("\nNo monitored patterns without matching config paths.");
+  }
+
   if (input.stale.length > 0) {
     console.log("\nStale coverage classifications:");
     for (const entry of input.stale) {
