fix(exec): distinguish one-shot from ask=always in approval prompt

ZOOWH · ZOOWH · commit 635555a44c03 · 2026-06-27T05:59:26.000+08:00
When Allow Always is unavailable because a command is one-shot (e.g. shell redirection), show the correct reason instead of falsely claiming the effective policy requires approval every time. Closes #97069
diff --git a/src/infra/exec-approval-reply.test.ts b/src/infra/exec-approval-reply.test.ts
@@ -368,6 +368,20 @@ describe("exec approval reply helpers", () => {
     expect(payload.interactive).toBeUndefined();
   });
 
+  it("shows one-shot reason when allow-always excluded but ask is not always", () => {
+    const payload = buildExecApprovalPendingReplyPayload({
+      approvalId: "req-one-shot",
+      approvalSlug: "slug-one-shot",
+      ask: "on-miss",
+      command: "openclaw --version 2>&1",
+      host: "gateway",
+      allowedDecisions: ["allow-once", "deny"],
+    });
+
+    expect(payload.text).toContain("cannot be saved for future use");
+    expect(payload.text).not.toContain("requires approval every time");
+  });
+
   it("stores agent and session metadata for downstream suppression checks", () => {
     const payload = buildExecApprovalPendingReplyPayload({
       approvalId: "req-meta",
diff --git a/src/infra/exec-approval-reply.ts b/src/infra/exec-approval-reply.ts
@@ -376,9 +376,11 @@ export function buildExecApprovalPendingReplyPayload(
     lines.push(secondaryFence);
   }
   if (!allowedDecisions.includes("allow-always")) {
-    lines.push(
-      "The effective approval policy requires approval every time, so Allow Always is unavailable.",
-    );
+    const reason =
+      params.ask === "always"
+        ? "The effective approval policy requires approval every time, so Allow Always is unavailable."
+        : "Allow Always is unavailable because this command cannot be saved for future use (e.g., shell redirection or one-shot arguments).";
+    lines.push(reason);
   }
   const info: string[] = [];
   info.push(`Host: ${params.host}`);
