Fix bash bang detection for markdown images

OpenClaw Assistant · OpenClaw Assistant · commit 6246b6e75b0d · 2026-03-11T19:56:43.000+08:00
diff --git a/src/auto-reply/reply/bash-command.ts b/src/auto-reply/reply/bash-command.ts
@@ -61,6 +61,9 @@ function formatOutputBlock(text: string) {
 
 function parseBashRequest(raw: string): BashRequest | null {
   const trimmed = raw.trimStart();
+  if (trimmed.startsWith("![")) {
+    return null;
+  }
   let restSource = "";
   if (trimmed.toLowerCase().startsWith("/bash")) {
     const match = trimmed.match(/^\/bash(?:\s*:\s*|\s+|$)([\s\S]*)$/i);
diff --git a/src/auto-reply/reply/commands-bash.ts b/src/auto-reply/reply/commands-bash.ts
@@ -9,7 +9,7 @@ export const handleBashCommand: CommandHandler = async (params, allowTextCommand
   const { command } = params;
   const bashSlashRequested =
     command.commandBodyNormalized === "/bash" || command.commandBodyNormalized.startsWith("/bash ");
-  const bashBangRequested = command.commandBodyNormalized.startsWith("!");
+  const bashBangRequested = /^!(?:\s|:|[a-z0-9]|$)/i.test(command.commandBodyNormalized);
   if (!bashSlashRequested && !(bashBangRequested && command.isAuthorizedSender)) {
     return null;
   }
diff --git a/src/auto-reply/reply/commands.test.ts b/src/auto-reply/reply/commands.test.ts
@@ -92,6 +92,11 @@ vi.mock("../../agents/pi-embedded.js", () => {
   };
 });
 
+const execToolExecuteMock = vi.hoisted(() => vi.fn());
+vi.mock("../../agents/bash-tools.js", () => ({
+  createExecTool: () => ({ execute: execToolExecuteMock }),
+}));
+
 vi.mock("../../infra/system-events.js", () => ({
   enqueueSystemEvent: vi.fn(),
 }));
@@ -657,14 +662,56 @@ describe("handleCommands bash alias", () => {
       commands: { bash: true, text: true },
       whatsapp: { allowFrom: ["*"] },
     } as OpenClawConfig;
-    for (const aliasCommand of ["!poll", "!stop"]) {
+    for (const aliasCommand of ["!poll", "! poll", "!stop"]) {
       resetBashChatCommandForTests();
       const params = buildParams(aliasCommand, cfg);
       const result = await handleCommands(params);
       expect(result.shouldContinue).toBe(false);
       expect(result.reply?.text).toContain("No active bash job");
     }
   });
+
+  it("does not treat markdown image syntax as a bash command", async () => {
+    const cfg = {
+      commands: { bash: true, text: true },
+      whatsapp: { allowFrom: ["*"] },
+    } as OpenClawConfig;
+    resetBashChatCommandForTests();
+    const params = buildParams("![image] hello", cfg);
+    const result = await handleCommands(params);
+    expect(result.shouldContinue).toBe(true);
+    expect(result.reply).toBeUndefined();
+  });
+
+  it("accepts bang aliases and /bash run commands", async () => {
+    const cfg = {
+      commands: { bash: true, text: true },
+      whatsapp: { allowFrom: ["*"] },
+    } as OpenClawConfig;
+    execToolExecuteMock.mockResolvedValue({
+      details: { status: "completed", exitCode: 0, aggregated: "ok" },
+      content: [],
+    });
+
+    const cases = [
+      { commandBody: "!ls", expectedCommand: "ls" },
+      { commandBody: "!: ls", expectedCommand: "ls" },
+      { commandBody: "/bash echo hi", expectedCommand: "echo hi" },
+    ];
+
+    for (const testCase of cases) {
+      resetBashChatCommandForTests();
+      execToolExecuteMock.mockClear();
+      const params = buildParams(testCase.commandBody, cfg);
+      const result = await handleCommands(params);
+      expect(result.shouldContinue).toBe(false);
+      expect(result.reply?.text).toContain(`bash: ${testCase.expectedCommand}`);
+      expect(execToolExecuteMock).toHaveBeenCalledWith(
+        "chat-bash",
+        expect.objectContaining({ command: testCase.expectedCommand }),
+      );
+    }
+  });
 });
 
 function buildPolicyParams(

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ export const handleBashCommand: CommandHandler = async (params, allowTextCommand`
`9`	`9`	`const { command } = params;`
`10`	`10`	`const bashSlashRequested =`
`11`	`11`	`command.commandBodyNormalized === "/bash" \|\| command.commandBodyNormalized.startsWith("/bash ");`
`12`		`- const bashBangRequested = command.commandBodyNormalized.startsWith("!");`
	`12`	`+ const bashBangRequested = /^!(?:\s\|:\|[a-z0-9]\|$)/i.test(command.commandBodyNormalized);`
`13`	`13`	`if (!bashSlashRequested && !(bashBangRequested && command.isAuthorizedSender)) {`
`14`	`14`	`return null;`
`15`	`15`	`}`