test(ui): harden stream:item toolprogress test coverage

kangjinghang · claude · kangjinghang · commit 60a5f1f1bc85 · 2026-06-14T22:06:42.000+08:00
- Add afterAll to clean up the window installed by beforeAll (only when
  we installed it, so we don't disturb sibling describe blocks that may
  rely on a pre-existing window).
- Add two guard tests for the stream:"item" branch in handleAgentEvent:
  events whose kind is not "tool" or whose phase is not "update" are
  ignored, leaving the entry's progressText untouched.

In-scope suite: 124 pass (was 122). No regressions.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/ui/src/ui/app-tool-stream.node.test.ts b/ui/src/ui/app-tool-stream.node.test.ts
@@ -1,5 +1,5 @@
 // @vitest-environment node
-import { afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
+import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
 import { ACTIVITY_ENTRY_LIMIT, ACTIVITY_OUTPUT_PREVIEW_LIMIT } from "./activity-model.ts";
 import {
   handleAgentEvent,
@@ -833,12 +833,25 @@ describe("app-tool-stream fallback lifecycle handling", () => {
 });
 
 describe("stream:item toolprogress events", () => {
+  let weSetWindow = false;
   beforeAll(() => {
     const globalWithWindow = globalThis as typeof globalThis & {
       window?: Window & typeof globalThis;
     };
     if (!globalWithWindow.window) {
       globalWithWindow.window = globalThis as unknown as Window & typeof globalThis;
+      weSetWindow = true;
+    }
+  });
+  afterAll(() => {
+    // Only clean up the window we installed; leave any pre-existing one
+    // intact so we don't disturb sibling describe blocks that may rely on it.
+    if (weSetWindow) {
+      const globalWithWindow = globalThis as typeof globalThis & {
+        window?: Window & typeof globalThis;
+      };
+      delete globalWithWindow.window;
+      weSetWindow = false;
     }
   });
 
@@ -910,6 +923,58 @@ describe("stream:item toolprogress events", () => {
     expect(host.toolStreamOrder).toHaveLength(0);
   });
 
+  it("ignores stream:item events whose kind is not 'tool'", () => {
+    const host = createHost();
+    handleAgentEvent(
+      host,
+      agentEvent("run-1", 1, "tool", {
+        phase: "start",
+        toolCallId: "id-1",
+        name: "trading_quick",
+      }),
+    );
+    handleAgentEvent(
+      host,
+      agentEvent("run-1", 2, "item", {
+        kind: "text",
+        phase: "update",
+        toolCallId: "id-1",
+        progressText: "should be ignored",
+      }),
+    );
+    const entry = host.toolStreamById.get("id-1");
+    expect(entry?.progressText).toBeUndefined();
+    expect(entry?.message.content).not.toContainEqual(
+      expect.objectContaining({ type: "toolprogress" }),
+    );
+  });
+
+  it("ignores stream:item tool events whose phase is not 'update'", () => {
+    const host = createHost();
+    handleAgentEvent(
+      host,
+      agentEvent("run-1", 1, "tool", {
+        phase: "start",
+        toolCallId: "id-1",
+        name: "trading_quick",
+      }),
+    );
+    handleAgentEvent(
+      host,
+      agentEvent("run-1", 2, "item", {
+        kind: "tool",
+        phase: "start",
+        toolCallId: "id-1",
+        progressText: "should be ignored",
+      }),
+    );
+    const entry = host.toolStreamById.get("id-1");
+    expect(entry?.progressText).toBeUndefined();
+    expect(entry?.message.content).not.toContainEqual(
+      expect.objectContaining({ type: "toolprogress" }),
+    );
+  });
+
   it("clears progressText when the final result arrives", () => {
     const host = createHost();
     handleAgentEvent(
