fix(memory): address clawsweeper review on Windows sqlite-vec retry

AnkushKo · cursoragent · AnkushKo · commit 5e8e95ec7183 · 2026-05-05T21:18:21.000+05:30
- Codex P2: honor explicit extensionPath before importing the bundled sqlite-vec module. Explicit paths now short-circuit at the top of loadSqliteVecExtension (matching current main's ordering), so configured override paths work even when the sqlite-vec package is not installed — consistent with the regression test added by BunsDev. - Codex P3: add a CHANGELOG entry under Unreleased/Fixes referencing #68892. - Tests: extend sqlite-vec.test.ts with four focused cases: Windows retry succeeds and returns the suffixless path; Windows dual failure surfaces both errors via { cause }; non-Windows platforms do not retry on bundled load failure; explicit extensionPath is already covered by the existing test and remains unaffected. Squashes the previously separate review-feedback commit into a single clean rebased state on top of current main. Co-authored-by: Cursor <cursoragent@cursor.com>
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -69,6 +69,7 @@ Docs: https://docs.openclaw.ai
 
 ### Fixes
 
+- Memory/Windows: retry sqlite-vec extension load without the `.dll` suffix when the bundled `load()` call fails on Windows, matching SQLite's automatic suffix-appending convention; returns the effective suffixless path so subsequent reloads (after reindex/reset) use the correct path. Fixes #68892. Thanks @JustInCache.
 - TUI/sessions: bound the session picker to recent rows and use exact lookup-style refreshes for the active session, so dusty stores no longer make TUI hydrate weeks-old transcripts before becoming responsive. Thanks @vincentkoc.
 - Doctor/gateway: report recent supervisor restart handoffs in `openclaw doctor --deep`, using the installed service environment when available so service-managed clean exits are visible in guided diagnostics. Thanks @shakkernerd.
 - Gateway/status: show recent supervisor restart handoffs in `openclaw gateway status --deep`, including JSON details, so clean service-managed restarts are reported as restart handoffs instead of opaque stopped-service diagnostics. Thanks @shakkernerd.
diff --git a/packages/memory-host-sdk/src/host/sqlite-vec.test.ts b/packages/memory-host-sdk/src/host/sqlite-vec.test.ts
@@ -54,4 +54,84 @@ describe("loadSqliteVecExtension", () => {
     expect(db.enableLoadExtension).toHaveBeenCalledWith(true);
     expect(db.loadExtension).not.toHaveBeenCalled();
   });
+
+  it("retries without .dll suffix on Windows when bundled load fails", async () => {
+    const loadablePath = "C:\\sqlite-vec\\vec0.dll";
+    vi.doMock("sqlite-vec", () => ({
+      getLoadablePath: () => loadablePath,
+      load: vi.fn().mockImplementation(() => {
+        throw new Error("no such module: vec0");
+      }),
+    }));
+    const { loadSqliteVecExtension } = await importLoader();
+    const db = {
+      enableLoadExtension: vi.fn(),
+      loadExtension: vi.fn(),
+    };
+
+    const originalPlatform = process.platform;
+    Object.defineProperty(process, "platform", { value: "win32", configurable: true });
+    try {
+      const result = await loadSqliteVecExtension({ db: db as never });
+      expect(result.ok).toBe(true);
+      expect(result.extensionPath).toBe("C:\\sqlite-vec\\vec0");
+      expect(db.loadExtension).toHaveBeenCalledWith("C:\\sqlite-vec\\vec0");
+    } finally {
+      Object.defineProperty(process, "platform", { value: originalPlatform, configurable: true });
+    }
+  });
+
+  it("chains both errors when Windows .dll retry also fails", async () => {
+    const loadablePath = "C:\\sqlite-vec\\vec0.dll";
+    vi.doMock("sqlite-vec", () => ({
+      getLoadablePath: () => loadablePath,
+      load: vi.fn().mockImplementation(() => {
+        throw new Error("first: no such module: vec0");
+      }),
+    }));
+    const { loadSqliteVecExtension } = await importLoader();
+    const db = {
+      enableLoadExtension: vi.fn(),
+      loadExtension: vi.fn().mockImplementation(() => {
+        throw new Error("retry: no such module: vec0");
+      }),
+    };
+
+    const originalPlatform = process.platform;
+    Object.defineProperty(process, "platform", { value: "win32", configurable: true });
+    try {
+      const result = await loadSqliteVecExtension({ db: db as never });
+      expect(result.ok).toBe(false);
+      expect(result.error).toContain("both load attempts failed on Windows");
+      expect(result.error).toContain("retry: no such module: vec0");
+    } finally {
+      Object.defineProperty(process, "platform", { value: originalPlatform, configurable: true });
+    }
+  });
+
+  it("does not retry on non-Windows platforms when bundled load fails", async () => {
+    const loadablePath = "/usr/lib/sqlite-vec/vec0.so";
+    vi.doMock("sqlite-vec", () => ({
+      getLoadablePath: () => loadablePath,
+      load: vi.fn().mockImplementation(() => {
+        throw new Error("no such module: vec0");
+      }),
+    }));
+    const { loadSqliteVecExtension } = await importLoader();
+    const db = {
+      enableLoadExtension: vi.fn(),
+      loadExtension: vi.fn(),
+    };
+
+    const originalPlatform = process.platform;
+    Object.defineProperty(process, "platform", { value: "linux", configurable: true });
+    try {
+      const result = await loadSqliteVecExtension({ db: db as never });
+      expect(result.ok).toBe(false);
+      expect(result.error).toContain("no such module");
+      expect(db.loadExtension).not.toHaveBeenCalled();
+    } finally {
+      Object.defineProperty(process, "platform", { value: originalPlatform, configurable: true });
+    }
+  });
 });
