fix(apple): preserve localized static labels

vincentkoc · vincentkoc · commit 5e4d71686a6a · 2026-07-01T05:19:12.000-07:00
diff --git a/apps/ios/Sources/Gateway/GatewayQuickSetupSheet.swift b/apps/ios/Sources/Gateway/GatewayQuickSetupSheet.swift
@@ -121,7 +121,7 @@ struct GatewayQuickSetupSheet: View {
         self.gatewayController.gateways.first
     }
 
-    private func fullRowToggle(_ title: String, isOn: Binding<Bool>) -> some View {
+    private func fullRowToggle(_ title: LocalizedStringKey, isOn: Binding<Bool>) -> some View {
         Toggle(title, isOn: isOn)
             .contentShape(Rectangle())
             .overlay {
diff --git a/apps/ios/WatchApp/Sources/WatchInboxView.swift b/apps/ios/WatchApp/Sources/WatchInboxView.swift
@@ -760,7 +760,7 @@ private struct WatchCompactMetric: View {
 }
 
 private struct WatchPrimaryLabel: View {
-    let title: String
+    let title: LocalizedStringKey
 
     var body: some View {
         HStack(spacing: 7) {
@@ -809,7 +809,7 @@ private struct WatchPageRail: View {
 }
 
 private struct WatchSecondaryLabel: View {
-    let title: String
+    let title: LocalizedStringKey
 
     var body: some View {
         Text(self.title)
@@ -829,7 +829,7 @@ private struct WatchSecondaryLabel: View {
 }
 
 private struct WatchSecondaryButton: View {
-    let title: String
+    let title: LocalizedStringKey
     let action: () -> Void
 
     var body: some View {
@@ -911,7 +911,7 @@ private struct WatchActionCard: View {
 }
 
 private struct WatchDecisionButton: View {
-    let title: String
+    let title: LocalizedStringKey
     let color: Color
     let action: () -> Void
 
diff --git a/scripts/apple-app-i18n.ts b/scripts/apple-app-i18n.ts
@@ -1,6 +1,6 @@
 import { mkdir, readFile, writeFile } from "node:fs/promises";
 import path from "node:path";
-import { fileURLToPath } from "node:url";
+import { fileURLToPath, pathToFileURL } from "node:url";
 import { NATIVE_I18N_LOCALES } from "./native-app-i18n.ts";
 
 const HERE = path.dirname(fileURLToPath(import.meta.url));
@@ -12,6 +12,17 @@ const APPLE_LOCALE_DIRECTORIES: Record<string, string> = {
   "zh-CN": "zh-Hans",
   "zh-TW": "zh-Hant",
 };
+const LOCALIZED_WRAPPER_CONTRACTS: Record<string, string[]> = {
+  "apps/ios/Sources/Gateway/GatewayQuickSetupSheet.swift": [
+    "fullRowToggle(_ title: LocalizedStringKey",
+  ],
+  "apps/ios/WatchApp/Sources/WatchInboxView.swift": [
+    "private struct WatchPrimaryLabel: View {\n    let title: LocalizedStringKey",
+    "private struct WatchSecondaryLabel: View {\n    let title: LocalizedStringKey",
+    "private struct WatchSecondaryButton: View {\n    let title: LocalizedStringKey",
+    "private struct WatchDecisionButton: View {\n    let title: LocalizedStringKey",
+  ],
+};
 
 const CATALOGS = [
   {
@@ -100,6 +111,15 @@ function stringsLiteral(value: string): string {
 
 export async function checkAppleAppI18n() {
   let checked = 0;
+  for (const [sourcePath, contracts] of Object.entries(LOCALIZED_WRAPPER_CONTRACTS)) {
+    const source = await readFile(path.join(ROOT, sourcePath), "utf8");
+    const missing = contracts.filter((contract) => !source.includes(contract));
+    if (missing.length) {
+      throw new Error(
+        `Apple i18n wrapper ${sourcePath} bypasses localized string lookup: ${missing.join(", ")}`,
+      );
+    }
+  }
   for (const spec of CATALOGS) {
     const catalogPath = path.join(ROOT, spec.path);
     const catalog = JSON.parse(await readFile(catalogPath, "utf8")) as Catalog;
@@ -185,7 +205,7 @@ export async function compileMacosLocalizations(outputDir: string) {
   }
 }
 
-if (process.argv[1] && import.meta.url === `file://${path.resolve(process.argv[1])}`) {
+if (process.argv[1] && import.meta.url === pathToFileURL(path.resolve(process.argv[1])).href) {
   const [command, flag, value] = process.argv.slice(2);
   if (command === "check") {
     await checkAppleAppI18n();

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ struct GatewayQuickSetupSheet: View {`
`121`	`121`	`self.gatewayController.gateways.first`
`122`	`122`	`}`
`123`	`123`
`124`		`- private func fullRowToggle(_ title: String, isOn: Binding<Bool>) -> some View {`
	`124`	`+ private func fullRowToggle(_ title: LocalizedStringKey, isOn: Binding<Bool>) -> some View {`
`125`	`125`	`Toggle(title, isOn: isOn)`
`126`	`126`	`.contentShape(Rectangle())`
`127`	`127`	`.overlay {`