fix(process): unexport Windows spawn sanitizer for knip

stantheman0128 · cursoragent · stantheman0128 · commit 5e45d16ab177 · 2026-07-19T19:40:03.000+08:00
Keep the win32 detached:false guard internal to spawnWithFallback so
knip no longer flags an unused export, and drop direct helper tests that
tripped check-test-types on readonly stdio tuples.

Co-authored-by: Cursor &lt;cursoragent@cursor.com&gt;
diff --git a/src/process/spawn-utils.test.ts b/src/process/spawn-utils.test.ts
@@ -3,7 +3,7 @@ import type { ChildProcess, SpawnOptions } from "node:child_process";
 import { EventEmitter } from "node:events";
 import { PassThrough } from "node:stream";
 import { describe, expect, it, vi } from "vitest";
-import { sanitizeSpawnOptionsForPlatform, spawnWithFallback } from "./spawn-utils.js";
+import { spawnWithFallback } from "./spawn-utils.js";
 
 function createStubChild() {
   const child = new EventEmitter() as ChildProcess;
@@ -34,31 +34,6 @@ function spawnOptionsAt(
   return options as SpawnOptions;
 }
 
-describe("sanitizeSpawnOptionsForPlatform", () => {
-  it("forces detached false on Windows when callers request detached true (#105528)", () => {
-    const sanitized = sanitizeSpawnOptionsForPlatform(
-      { detached: true, stdio: ["pipe", "pipe", "pipe"], windowsHide: true },
-      "win32",
-    );
-    expect(sanitized.detached).toBe(false);
-    expect(sanitized.windowsHide).toBe(true);
-    expect(sanitized.stdio).toEqual(["pipe", "pipe", "pipe"]);
-  });
-
-  it("leaves detached true alone on POSIX", () => {
-    const sanitized = sanitizeSpawnOptionsForPlatform(
-      { detached: true, stdio: ["ignore", "pipe", "pipe"] },
-      "linux",
-    );
-    expect(sanitized.detached).toBe(true);
-  });
-
-  it("leaves already-attached Windows options unchanged", () => {
-    const options = { detached: false, stdio: ["pipe", "pipe", "pipe"] as const };
-    expect(sanitizeSpawnOptionsForPlatform(options, "win32")).toBe(options);
-  });
-});
-
 describe("spawnWithFallback", () => {
   it("retries on EBADF using fallback options", async () => {
     const spawnMock = vi
diff --git a/src/process/spawn-utils.ts b/src/process/spawn-utils.ts
@@ -29,11 +29,12 @@ const DEFAULT_RETRY_CODES = ["EBADF"];
 /**
  * On Windows, `detached: true` can break stdout/stderr pipe capture for
  * headless hosts (Scheduled Task / service) so exec/read-style tools return
- * empty output with no error. Call sites mostly opt out already; keep a
- * central belt-and-suspenders guard so every spawnWithFallback caller is safe.
+ * empty output with no error. The sole production caller
+ * (`createChildAdapter`) already opts out on win32; keep this as a local
+ * guard so future spawnWithFallback callers cannot reintroduce the footgun.
  * See #105528 / historical #17806 / #18035.
  */
-export function sanitizeSpawnOptionsForPlatform(
+function sanitizeSpawnOptionsForPlatform(
   options: SpawnOptions,
   platform: NodeJS.Platform = process.platform,
 ): SpawnOptions {
