Keep embedded delivery mirrors out of provider replay

alexzhu0 · alexzhu0 · commit 5dcee2eae584 · 2026-06-03T01:23:51.000+08:00
Embedded assistant gap-fill transcript rows are display-only delivery state. Store them as OpenClaw delivery mirrors so provider replay filters do not mistake child provider text for provider conversation state.

Constraint: Embedded gap-fill transcript rows are display-only state and must match existing transcript-only replay filters.

Rejected: Preserve child runtime provider/model metadata for gap-fill rows | that makes display mirrors look like provider conversation state.

Confidence: high

Scope-risk: narrow

Directive: Do not tag embedded assistant gap-fill mirrors with child provider/model metadata unless replay filters are updated with an equivalent transcript-only contract.

Tested: git diff --check origin/main...HEAD; oxlint changed files; targeted Vitest attempt-execution/replay-history suites (3 files, 95 passed); tsgo core-test project; codex review --base origin/main.

Not-tested: No live provider-managed thinking/signature conversation was replayed end to end; external raw transcript consumers may observe the intentional gap-fill metadata change.
diff --git a/src/agents/command/attempt-execution.cli.test.ts b/src/agents/command/attempt-execution.cli.test.ts
@@ -93,7 +93,13 @@ async function readSessionMessages(sessionFile: string) {
     .filter((entry) => entry.type === "message")
     .map(
       (entry) =>
-        entry.message as { role?: string; content?: unknown; provider?: string; model?: string },
+        entry.message as {
+          role?: string;
+          content?: unknown;
+          api?: string;
+          provider?: string;
+          model?: string;
+        },
     );
 }
 
@@ -770,6 +776,9 @@ describe("CLI attempt execution", () => {
     expect(messages).toHaveLength(1);
     expectRecordFields(requireRecord(messages[0], "assistant message"), {
       role: "assistant",
+      api: "openai-responses",
+      provider: "openclaw",
+      model: "delivery-mirror",
       content: [{ type: "text", text: "already mirrored" }],
     });
 
diff --git a/src/agents/command/attempt-execution.ts b/src/agents/command/attempt-execution.ts
@@ -365,6 +365,18 @@ export async function persistCliTurnTranscript(params: {
   const provider = params.result.meta.agentMeta?.provider?.trim() ?? "cli";
   const model = params.result.meta.agentMeta?.model?.trim() ?? "default";
   const gapFill = params.embeddedAssistantGapFill ?? false;
+  const assistant = gapFill
+    ? {
+        api: "openai-responses",
+        provider: "openclaw",
+        model: "delivery-mirror",
+      }
+    : {
+        api: "cli",
+        provider,
+        model,
+        usage: params.result.meta.agentMeta?.usage,
+      };
 
   return await persistTextTurnTranscript({
     body: gapFill ? "" : params.body,
@@ -381,12 +393,7 @@ export async function persistCliTurnTranscript(params: {
     sessionCwd: params.sessionCwd,
     config: params.config,
     embeddedAssistantGapFill: gapFill,
-    assistant: {
-      api: "cli",
-      provider,
-      model,
-      usage: params.result.meta.agentMeta?.usage,
-    },
+    assistant,
   });
 }
 
