fix(slack): bound conversation info cache

zhangguiping-xydt · zhangguiping-xydt · commit 56aa859e74ce · 2026-07-07T16:03:43.000+08:00
diff --git a/extensions/slack/src/channel-type.test.ts b/extensions/slack/src/channel-type.test.ts
@@ -178,6 +178,55 @@ describe("resolveSlackChannelType", () => {
     expect(conversationsInfoMock).not.toHaveBeenCalled();
   });
 
+  it("evicts least-recently-used conversation info entries after the cache limit", async () => {
+    const cacheMaxEntries = 1024;
+    const cfg = {
+      channels: {
+        slack: {
+          botToken: "xoxb-test",
+        },
+      },
+    } as never;
+
+    conversationsInfoMock.mockImplementation(async ({ channel }) => ({
+      channel: {
+        id: channel,
+      },
+    }));
+
+    for (let index = 0; index < cacheMaxEntries; index++) {
+      await resolveSlackConversationInfo({
+        cfg,
+        channelId: `C${index.toString().padStart(8, "0")}`,
+      });
+    }
+    expect(conversationsInfoMock).toHaveBeenCalledTimes(cacheMaxEntries);
+
+    await resolveSlackConversationInfo({
+      cfg,
+      channelId: "C00000000",
+    });
+    expect(conversationsInfoMock).toHaveBeenCalledTimes(cacheMaxEntries);
+
+    await resolveSlackConversationInfo({
+      cfg,
+      channelId: `C${cacheMaxEntries.toString().padStart(8, "0")}`,
+    });
+    expect(conversationsInfoMock).toHaveBeenCalledTimes(cacheMaxEntries + 1);
+
+    await resolveSlackConversationInfo({
+      cfg,
+      channelId: "C00000001",
+    });
+    expect(conversationsInfoMock).toHaveBeenCalledTimes(cacheMaxEntries + 2);
+
+    await resolveSlackConversationInfo({
+      cfg,
+      channelId: "C00000000",
+    });
+    expect(conversationsInfoMock).toHaveBeenCalledTimes(cacheMaxEntries + 2);
+  });
+
   it("preserves the channel-type wrapper contract", async () => {
     conversationsInfoMock.mockResolvedValueOnce({
       channel: {
diff --git a/extensions/slack/src/channel-type.ts b/extensions/slack/src/channel-type.ts
@@ -13,8 +13,33 @@ export type SlackConversationInfo = {
   user?: string;
 };
 
+const SLACK_CONVERSATION_INFO_CACHE_MAX_ENTRIES = 1024;
 const SLACK_CONVERSATION_INFO_CACHE = new Map<string, SlackConversationInfo>();
 
+function getCachedSlackConversationInfo(cacheKey: string): SlackConversationInfo | undefined {
+  const cached = SLACK_CONVERSATION_INFO_CACHE.get(cacheKey);
+  if (cached) {
+    SLACK_CONVERSATION_INFO_CACHE.delete(cacheKey);
+    SLACK_CONVERSATION_INFO_CACHE.set(cacheKey, cached);
+  }
+  return cached;
+}
+
+function setCachedSlackConversationInfo(
+  cacheKey: string,
+  conversationInfo: SlackConversationInfo,
+): void {
+  if (SLACK_CONVERSATION_INFO_CACHE.has(cacheKey)) {
+    SLACK_CONVERSATION_INFO_CACHE.delete(cacheKey);
+  } else if (SLACK_CONVERSATION_INFO_CACHE.size >= SLACK_CONVERSATION_INFO_CACHE_MAX_ENTRIES) {
+    const oldest = SLACK_CONVERSATION_INFO_CACHE.keys().next().value;
+    if (typeof oldest === "string") {
+      SLACK_CONVERSATION_INFO_CACHE.delete(oldest);
+    }
+  }
+  SLACK_CONVERSATION_INFO_CACHE.set(cacheKey, conversationInfo);
+}
+
 export async function resolveSlackConversationInfo(params: {
   cfg: OpenClawConfig;
   accountId?: string | null;
@@ -26,7 +51,7 @@ export async function resolveSlackConversationInfo(params: {
   }
   const account = resolveSlackAccount({ cfg: params.cfg, accountId: params.accountId });
   const cacheKey = `${account.accountId}:${channelId}`;
-  const cached = SLACK_CONVERSATION_INFO_CACHE.get(cacheKey);
+  const cached = getCachedSlackConversationInfo(cacheKey);
   if (cached) {
     return cached;
   }
@@ -42,7 +67,7 @@ export async function resolveSlackConversationInfo(params: {
       groupChannels.includes(`mpim:${channelIdLower}`))
   ) {
     const result = { type: "group" } as const;
-    SLACK_CONVERSATION_INFO_CACHE.set(cacheKey, result);
+    setCachedSlackConversationInfo(cacheKey, result);
     return result;
   }
 
@@ -59,7 +84,7 @@ export async function resolveSlackConversationInfo(params: {
     })
   ) {
     const result = { type: "channel" } as const;
-    SLACK_CONVERSATION_INFO_CACHE.set(cacheKey, result);
+    setCachedSlackConversationInfo(cacheKey, result);
     return result;
   }
 
@@ -70,7 +95,7 @@ export async function resolveSlackConversationInfo(params: {
   if (!token) {
     const result = { type: isNativeImChannel ? "dm" : "unknown" } as const;
     if (!isNativeImChannel) {
-      SLACK_CONVERSATION_INFO_CACHE.set(cacheKey, result);
+      setCachedSlackConversationInfo(cacheKey, result);
     }
     return result;
   }
@@ -89,20 +114,20 @@ export async function resolveSlackConversationInfo(params: {
           : undefined;
       const result: SlackConversationInfo = user ? { type: "dm", user } : { type: "dm" };
       if (user) {
-        SLACK_CONVERSATION_INFO_CACHE.set(cacheKey, result);
+        setCachedSlackConversationInfo(cacheKey, result);
       }
       return result;
     }
     const info = await client.conversations.info({ channel: channelId });
     const channel = info.channel as { is_im?: boolean; is_mpim?: boolean } | undefined;
     const type = channel?.is_im ? "dm" : channel?.is_mpim ? "group" : "channel";
     const result = { type } as const;
-    SLACK_CONVERSATION_INFO_CACHE.set(cacheKey, result);
+    setCachedSlackConversationInfo(cacheKey, result);
     return result;
   } catch {
     const result = { type: isNativeImChannel ? "dm" : "unknown" } as const;
     if (!isNativeImChannel) {
-      SLACK_CONVERSATION_INFO_CACHE.set(cacheKey, result);
+      setCachedSlackConversationInfo(cacheKey, result);
     }
     return result;
   }
